bugXBoard - Bugs: bug #27760, debug printf in backend.c

 
 

bug #27760: debug printf in backend.c

Submitted by:  None
Submitted on:  Tue 20 Oct 2009 07:35:08 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Assigned to: NoneOpen/Closed: Closed
Release: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 21 Oct 2009 02:01:08 AM UTC, comment #3:

uploaded fix and closing this.

Arun Persaud <apersaud>
Project Administrator
Tue 20 Oct 2009 09:55:48 AM UTC, comment #2:

I recently had exposure to this and formed one thought: why not design the debug facility so that it is not necessary to always check for appData.debugMode?

That extra check really uglifies the code. At least for the GTK version we ought to simply have it become a call that operates peroperly based on if -debug was passed or not. Plus, as this bug report notes, it's easy enough to leave behind a buggy call to the debugging system. It's horrid as is.

Eric Mullins <nematocyst>
Project Member
Tue 20 Oct 2009 09:27:04 AM UTC, comment #1:

Ah, sorry. A leftover of my debugging efforts that should actually have been removed altogether now that things work. Thanks for spotting it.

Perhaps many "fprintf(debugFP, ..." that are controlled by appData.debugMode should be deleted as well. (Especially in the legality testing / disambiguation in moves.c; I have not seen any erroneous illegal-move calls there for years.) We really should clean up the code in that respect one day.

H.G. Muller

Anonymous
Tue 20 Oct 2009 07:35:08 AM UTC, original submission:

Xboard:
With version v4.4.1.20091019 in backend.c (line 3432) a
fprintf(debugFP ...
was introduced. It is not controlled by "if (appData.debugMode)".
So it spams the console.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by apersaud (Posted a comment)
  • -unavailable- added by nematocyst (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 21 Oct 2009 02:01:08 AM UTCapersaudOpen/ClosedOpen=>Closed
      StatusNone=>Fixed

    Back to the top


    Powered by Savane 3.1-cleanup1