bugGNUstep - Bugs: bug #27636, Scrollbar a few pixel off on...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #27636: Scrollbar a few pixel off on NSWindows95InterfaceStyle

Submitted by:  Stef <stefanbidi>
Submitted on:  Fri 09 Oct 2009 02:42:57 AM UTC  
 
Category: Gui/AppKitSeverity: 3 - Normal
Item Group: BugStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

(Jump to the original submission Jump to the original submission)

Tue 10 Nov 2009 07:27:59 AM UTC, comment #9:

confirmed as fixed.

Richard Frith-Macdonald <CaS>
Project Member
Mon 09 Nov 2009 10:28:29 PM UTC, comment #8:

Looks good to me!

Stef <stefanbidi>
Project Member
Mon 09 Nov 2009 11:47:51 AM UTC, comment #7:

I've been through this code, simplified/clarified a little I hope, and fixed a minor offset error which could have been your issue.
Please could you give it a go and see if this now acts as you expect.

Richard Frith-Macdonald <CaS>
Project Member
Sat 07 Nov 2009 10:23:51 PM UTC, comment #6:

I guess the offset that I saw at the bottom was just my eyes playing tricks on me. I just took at look at it again and don't see anything, so forget that statement.

Stef <stefanbidi>
Project Member
Sat 07 Nov 2009 09:51:26 PM UTC, comment #5:

I checked this and the layout is the same for the cairo and the xlib backend. Next I looked into the NSScroller code and there the difference is even documented in a comment:

/* We use the button offset if we in the NeXTstep interface style. */
if (interfaceStyle == NSNextStepInterfaceStyle
|| interfaceStyle == NSMacintoshInterfaceStyle
|| interfaceStyle == GSWindowMakerInterfaceStyle)
{
buttonsWidth = ([isa scrollerWidth] - buttonsOffset);
x = y = 1.0;
buttonsSize = 2 * buttonsWidth + 2;
}
else
{
buttonsWidth = [isa scrollerWidth];
x = y = 1.0;
buttonsSize = 2 * buttonsWidth;
}

So I think this difference is there intentionally, or at least was so originally. I could not drag down who added this code (SVN blames gives Richard, but he may just have rearranged that method) perhaps somebody on this list remembers the reason for this?

As for the vertical offset, I see the same on the screen shot with the NSMacintoshInterfaceStyle. What is the difference I am missing?

Fred Kiefer <FredKiefer>
Project Member
Fri 23 Oct 2009 02:13:17 AM UTC, comment #4:

Oh, and I'm using the Xlib backend.

Stef <stefanbidi>
Project Member
Fri 23 Oct 2009 01:00:03 AM UTC, comment #3:

Sorry it took me a while to reply... screen shots are attached. I made one with the Mac and one with Win interface styles for comparison.

(file #18933, file #18934)

Stef <stefanbidi>
Project Member
Mon 12 Oct 2009 03:05:51 PM UTC, comment #2:

One more question: Which backend are you using? Riccardo has reported a small offset between art and other backends. I still haven't found time to look into that.
If your problem goes away when switching to cairo, then it is most likely that other issue.

Fred Kiefer <FredKiefer>
Project Member
Sun 11 Oct 2009 08:26:54 PM UTC, comment #1:

A screen shot really would help. I tried to reproduce this behaviour with Ink, but could not see the described offset.

I only set the NSInterfaceStyleDefault to NSWindows95InterfaceStyle and didn't use any theme. If the issue only shows up for the theme, it must be regarded as a theme problem.

Fred Kiefer <FredKiefer>
Project Member
Fri 09 Oct 2009 02:42:57 AM UTC, original submission:

I've noticed this when using Riccardo's WinClass theme or just setting NSInterfaceStyleDefault = NSWindows95InterfaceStyle.

  • The whole bar seems to be about 1 pixel to the right;
  • The bottom button is about 2 pixel up;
  • Top button is about 1 pixel below.

Let me know if a screen shot is needed, I don't have a way to take one, yet.

Stef <stefanbidi>
Project Member

 

Attached Files
file #18934:  NSWin95IntStyle.png added by stefanbidi (91KiB - image/png)
file #18933:  NSMacIntStyle.png added by stefanbidi (86KiB - image/png)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by CaS (Posted a comment)
  • -unavailable- added by FredKiefer (Posted a comment)
  • -unavailable- added by stefanbidi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 10 Nov 2009 07:27:59 AM UTCCaSOpen/ClosedIn Test=>Closed
    Mon 09 Nov 2009 11:47:51 AM UTCCaSStatusNone=>Fixed
      Open/ClosedOpen=>In Test
    Fri 23 Oct 2009 01:00:03 AM UTCstefanbidiAttached File-=>Added NSWin95IntStyle.png, #18934
      Attached File-=>Added NSMacIntStyle.png, #18933
    Sun 11 Oct 2009 08:26:53 PM UTCFredKieferCategoryBackend=>Gui/AppKit

    Back to the top


    Powered by Savane 3.1-cleanup1