bugmake - Bugs: bug #27545, Patch to add Makefile.mak to...

 
 

bug #27545: Patch to add Makefile.mak to default file names searched

Submitter:  J <now3d>
Submitted:  Sun 27 Sep 2009 10:36:55 PM UTC
   
 
Severity:  1 - Wish Priority:  5 - Normal
Item Group:  Enhancement Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open Component Version:  3.82
Operating System:  Any Fixed Release:  None
Triage Status:  None
* Mandatory Fields

Post a Comment

Add a New Comment Rich Markup
   

Discussion

Sun 04 Oct 2009 12:40:21 PM UTC, comment #2: 

Boris. You make a good point about not processing NMAKE files. However lots of "make" tools like Borland I believe also check for "Makefile.mak".

The main point of this bug ticket is to have an extension (filetype) on the filename, so editors can be easily set up to open the files; the ".mak" extension.

My revised patch instead adds "GNUMakefile.mak" too the filename list. What do you think about this proposal?

Attachment attached.

(file #18812)

J <now3d>
Mon 28 Sep 2009 07:42:21 AM UTC, comment #1: 

If you refer to Microsoft nmake, then you probably know that nmake and GNU make have very different and incompatible makefile syntax. Making GNU make automatically trying to process nmake makefiles doesn't sound like a good idea since it will fail for most non-trivial ones.

Boris Kolpackov <bosk>
Group Member
Sun 27 Sep 2009 10:36:55 PM UTC, original submission:  

Makefile.mak files are very common, and supported by other "make" varieties such as NMAKE. Therefore I created this patch for GNU Make to also search for "Makefile.mak"

On MS Windows it is very useful for a file to have a file extension, then it can be clicked on to open, as it is associated with a text editor. When there is no extension it's necessary to manually open it, which slows things down when this is your main task!

Jon

read.c patch attached.

I've posted this before as an email, no reply though then.
http://www.mail-a ... org/msg04763.html

J <now3d>

 

Attached Files

Attached Files
file #18812:  GNUMakefile_mak_read_c.patch added by now3d (410B - text/x-patch)
file #18788:  makefile_mak_read_c.patch added by now3d (422B - text/x-patch - read.c patch to add Makefile.mak to list of files scanned.)

(Note: upload size limit is set to 4.0MiB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Dependencies

This item does not depend on any other items.

No items depend on this one.

 

Mail Notification Carbon-Copy List

Carbon-Copy List
  • -email is unavailable- added by psmith (Updated the item)
  • -email is unavailable- added by bosk (Posted a comment)
  • -email is unavailable- added by now3d (Submitted the item)
  •  

    Votes

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

    History

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-10-09 psmith Component Version4.0 3.82
    2009-10-04 now3d Attached File- Added GNUMakefile_mak_read_c.patch, #18812
    2009-09-28 bosk Severity3 - Normal 1 - Wish
        Item GroupNone Enhancement
    2009-09-27 now3d Attached File- Added makefile_mak_read_c.patch, #18788

    Back to the top

    Powered by Savane 3.16-598c.
    Corresponding source code