bugGNU Wget - Bugs: bug #27080, add support for libproxy

 
 

bug #27080: add support for libproxy

Submitter:  Pablo Castorino <castorinop>
Submitted:  Thu 23 Jul 2009 05:06:07 AM UTC
   
 
Category:  Feature Request Severity:  1 - Wish
Priority:  3 - Low Status:  Needs Discussion
Privacy:  Public Assigned to:  None
Originator Name:  Pablo Castorino Open/Closed:  Open
Release:  1.11.4 Operating System:  GNU/Linux
Reproducibility:  None Fixed Release:  None
Planned Release:  1.15 Regression:  None
Work Required:  None Patch Included:  No
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 02 Oct 2009 05:36:19 PM UTC, comment #4: 

Hi Pablo, thank you for your patch.

I can't accept it as it currently stands, for the following reasons:

  • free(px) is dangerous, px_proxy_factory_free should be used instead.
  • The indentation and coding style does not match Wget's guidelines; see the "Standards and coding style" section of http://wget.addictivecode.org/PatchGuidelines
  • A dependency on pkgconfig is introduced that I'd prefer to avoid if possible.


Dominique Leuenberger, one of the libproxy developers, has also supplied a patch, which looks a bit more suitable; however, it too needs some adjustments (outlined in the mailing list; hasn't shown up in the archives yet).

I'm going to set Patch: No to remove it from my queue of unreviewed patches, until I hear back on Dominique regarding the suggested changes.

Micah Cowan <micahcowan>
Thu 10 Sep 2009 07:19:01 PM UTC, comment #3: 
Micah Cowan <micahcowan>
Tue 01 Sep 2009 12:48:08 PM UTC, comment #2: 

updated patch, better check libproxy response

(file #18665)

Pablo Castorino <castorinop>
Thu 23 Jul 2009 07:20:06 AM UTC, comment #1: 

Current development sources are at http://hg.addictivecode.org/wget/mainline, patches should be against that.

Micah Cowan <micahcowan>
Thu 23 Jul 2009 05:06:07 AM UTC, original submission:  

this patch provide a libproxy (http://code.google.com/p/libproxy/) integration and autotools config.

Regards

Pablo Castorino <castorinop>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #18665:  wget-mainline-078ccbf5d52a-libproxy.patch added by castorinop (3KiB - application/octet-stream)
file #18467:  wget-mainline-2cce7a3db9ce-libproxy.patch added by castorinop (6KiB - application/octet-stream - updated patch for mainline 2cce7a3db9ce)
file #18456:  wget-1.11.4-libproxy.patch added by castorinop (4KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by micahcowan (Posted a comment)
  • -email is unavailable- added by castorinop (Submitted the item)
  • -email is unavailable- added by castorinop
  •  

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-10-02 micahcowan Patch IncludedYes No
    2009-09-01 castorinop Attached File- Added wget-mainline-078ccbf5d52a-libproxy.patch, #18665
    2009-08-22 micahcowan Summaryadd support librpoxy add support for libproxy
    2009-07-24 castorinop Attached File- Added wget-mainline-2cce7a3db9ce-libproxy.patch, #18467
    2009-07-23 micahcowan Severity3 - Normal 1 - Wish
        Priority5 - Normal 3 - Low
        StatusNone Needs Discussion
        Planned ReleaseNone 1.15
    2009-07-23 castorinop Attached File- Added wget-1.11.4-libproxy.patch, #18456
        Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code