bugGnash - The GNU Flash player - Bugs: bug #27071, Crash with gst sound (OSS/ALSA...

 
 

bug #27071: Crash with gst sound (OSS/ALSA issue?)

Submitted by:  None
Submitted on:  Tue 21 Jul 2009 08:13:21 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 07 Aug 2009 01:01:45 PM UTC, comment #2:

Patch committed, bug reported fixed. Thanks.

Benjamin Wolsey <bwy>
Project Member
Fri 07 Aug 2009 09:59:51 AM UTC, comment #1:

According to the SDL Docs:
int SDL_OpenAudio(SDL_AudioSpec desired, SDL_AudioSpec obtained);

> If obtained is NULL then the desired SDL_AudioSpec is your working specification, otherwise the obtained SDL_AudioSpec becomes the working specification and the desired specification can be deleted.


So, when the audio is opened desired is modified to fit the audio device chosen.

This error is caused because the audio is first tested and sound parameters chosen, and then when it tries to use those same parameters to open a different sound device it gets an error. The fix is to reinitialize the SDL_AudioSpec every time we open the audio device. The attached patch does that.

(file #18536)

Ed Martin <edman007>
Tue 21 Jul 2009 08:13:21 PM UTC, original submission:

When i have mplayer open, using ALSA, OSS is not available and gnash which uses gst-ffmpeg will fall back to ALSA, and audio works. When i don't have mplayer running it just uses OSS. If mplayer is using ALSA which makes OSS unavailable when gnash is started (at the time FF loads the page with the flash video on it) and I then quit mplayer before clicking the "click to play" button (which i suppose just changes the list of available audio devices) then gnash will just exit with an error when i click the "click to play" button. There is no issue if mplayer is quit after the button has been pressed or before gnash has been started.

And the error i get is:

terminate called after throwing an instance of 'gnash::SoundException'
what(): Unable to open SDL audio: Fragment size must be a power of two

that is all i see in the logs, nothing else

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #18536:  sound-fix.patch added by edman007 (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bwy (Updated the item)
  • -unavailable- added by edman007 (Updated the item)
  • -unavailable- added by edman007
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 07 Aug 2009 01:01:45 PM UTCbwyStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Fri 07 Aug 2009 12:12:28 PM UTCbwyStatusNone=>Ready For Test
    Fri 07 Aug 2009 09:59:51 AM UTCedman007Attached File-=>Added sound-fix.patch, #18536
    Sun 26 Jul 2009 11:49:06 PM UTCedman007Carbon-Copy-=>Added edman007

    Back to the top


    Powered by Savane 3.1-cleanup1