bugGnash - The GNU Flash player - Bugs: bug #26994, DefineBitsJPEG{2,3,4} loaders...

 
 

bug #26994: DefineBitsJPEG{2,3,4} loaders don't support PNG & GIFs

Submitted by:  None
Submitted on:  Thu 09 Jul 2009 05:50:36 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 20 Oct 2010 05:53:07 PM UTC, comment #4:

This is now implemented as documented for DefineBits3 and the newly-added DefineBits4. It's not tested for either, and DefineBits4 isn't tested at all, but we may notice now if there are some bugs. Report them if there are!

Benjamin Wolsey <bwy>
Project Member
Mon 13 Jul 2009 08:54:23 AM UTC, comment #3:

No, I haven't touched the DefineBits3 loader, as I have nothing to test it with at the moment. Same with DefineBits4.

Benjamin Wolsey <bwy>
Project Member
Mon 13 Jul 2009 08:47:12 AM UTC, comment #2:

I can confirm that this works for DefineBitsJPEG2.

However from the patch, I don't think this will work for DefineBitsJPEG3. (and 4 obviously since not implemented :).

It also fixes the alpha issue I had when doing a patch locally.

Anonymous
Fri 10 Jul 2009 06:09:07 AM UTC, comment #1:

Gnash should now display the attached AS2 file correctly. I verified that the image is shown even when the SWF version is less than 8 (unlike loaded bitmaps). Revno 11242.

Benjamin Wolsey <bwy>
Project Member
Thu 09 Jul 2009 05:50:36 PM UTC, original submission:

This is new :

-----
In addition to specifying JPEG data, DefineBitsJPEG{2,3,4} can also contain PNG image data and non-animated GIF89a image data.

- If ImageData begins with the eight bytes 0x89 0x50 0x4E 0x47 0x0D 0x0A 0x1A 0x0A, the ImageData contains PNG data.
- If ImageData begins with the six bytes 0x47 0x49 0x46 0x38 0x39 0x61, the ImageData contains GIF89a data.

If ImageData contains PNG or GIF89a data, the optional BitmapAlphaData is not supported.
-----

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #18399:  whatever-alpha.png added by None (6KiB - image/png - Some test cases (The source PNG with alpha, then a AVM1 & AVM2 file using it))
file #18400:  test_as2_png.swf added by None (6KiB - application/x-shockwave-flash - Some test cases (The source PNG with alpha, then a AVM1 & AVM2 file using it))
file #18401:  test_as3_png.swf added by None (6KiB - application/x-shockwave-flash - Some test cases (The source PNG with alpha, then a AVM1 & AVM2 file using it))

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bwy (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 20 Oct 2010 05:53:07 PM UTCbwyStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Fri 10 Jul 2009 06:09:07 AM UTCbwyStatusNone=>Ready For Test
    Thu 09 Jul 2009 08:13:21 PM UTCNoneAttached File-=>Added whatever-alpha.png, #18399
      Attached File-=>Added test_as2_png.swf, #18400
      Attached File-=>Added test_as3_png.swf, #18401

    Back to the top


    Powered by Savane 3.1-cleanup1