bugDenemo - Bugs: bug #26987, infodialogs have no parent window

 
 

bug #26987: infodialogs have no parent window

Submitted by:  None
Submitted on:  Thu 09 Jul 2009 12:35:24 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 09 Jul 2009 12:59:18 PM UTC, comment #1:

I have applied the same fix to the other types of dialog. Thank you for a thorough report.

Richard Shann <rshann>
Project Administrator
Thu 09 Jul 2009 12:35:24 PM UTC, original submission:

infodialog's gtk_window_new call in src/utils.c has "NULL" as first parameter: that means that the dialog isn't bound a toplevel window, and if for instance I change workspace (before it appears, which is absolutely possible for instance in the case of pdf generation), I may get it floating somewhere (where it may as well remain until I notice it), and it may as well hide under another window. This is really ugly and unusable.

I'm attaching a simple patch, which registers its parent as the main Denemo window. It's possibly not optimal (maybe some infodialogs stem from seconday windows and should be bound to that), but it's far better than before.

The patch is again git (though I tested the modification against 0.8.6 only, but there should be no problem against git too).

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #18387:  0001-The-infodialog-now-has-a-parent-window-to-improve-u.patch added by None (776B - text/x-diff - Patch (against git commit f1e1ae8f2eed80556798a4511442d0190828e324))

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by steele (Updated the item)
  • -unavailable- added by rshann (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 04 Dec 2010 01:07:39 PM UTCsteeleOpen/ClosedOpen=>Closed
    Thu 09 Jul 2009 12:59:18 PM UTCrshannStatusNone=>Fixed
    Thu 09 Jul 2009 12:35:24 PM UTCNoneAttached File-=>Added 0001-The-infodialog-now-has-a-parent-window-to-improve-u.patch, #18387

    Back to the top


    Powered by Savane 3.1-cleanup1