bugGNU GRUB - Bugs: bug #26924, [grub2] grub-install...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #26924: [grub2] grub-install --root-directory=... /dev/partition does not work

Submitted by:  Kano <kano>
Submitted on:  Tue 30 Jun 2009 10:54:15 PM UTC  
 
Category: InstallationSeverity: Major
Priority: 5 - NormalItem Group: None
Status: NonePrivacy: Public
Assigned to: NoneOriginator Name: 
Open/Closed: ClosedRelease: 1.96+20090629
Release: Bazaar - trunkReproducibility: Every Time
Planned Release: None

Wed 25 Nov 2009 12:53:51 PM UTC, comment #4:

Actually this should be fixed in trunk now too.
I added make_system_path_relative_to_its_root() to grub-setup.
And when I tested it it worked for me. (And revealed some strangeness with ntfs-3g and our ntfs code)

Felix Zielcke <fzielcke>
Project Member
Wed 25 Nov 2009 12:44:08 AM UTC, comment #3:

Now that Felix' mkrelpath branch has been merged in trunk, it should be possible to implement this without too much hassle.

I still don't consider it a priority, but anyhow... patches welcome.

Robert Millan <robertmh>
Project Administrator
Sat 04 Jul 2009 08:08:00 PM UTC, comment #2:

> Considering that this whole mess is only for the sake of
> supporting blocklists, which are DEPRECATED, I think the best
> option is to print a nice error and abort.


Which I just notice we're already doing. In fact you need to use --force to reproduce this error, otherwise grub-setup stops earlier.

Robert Millan <robertmh>
Project Administrator
Sat 04 Jul 2009 08:03:13 PM UTC, comment #1:

This patch only works by pure chance. Turns out, the core.img you had in /boot/grub/ was identical to the one you're installing to your target (designated by --root-directory=).

There's no "right way" to use /boot/grub/core.img for the consistency check, it's simply the wrong one.

As for using the right one, this would involve a few ugly kludges, since we need grub-install to tell grub-setup about:

a) the GRUB drive in which is is hosted
b) its relative path

and then, if the desired GRUB drive doesn't match with the drive we're installing boot.img to, we need to fallback to UUIDs, which is handled in grub-install anyway.

Considering that this whole mess is only for the sake of supporting blocklists, which are DEPRECATED, I think the best option is to print a nice error and abort.

Robert Millan <robertmh>
Project Administrator
Tue 30 Jun 2009 10:54:15 PM UTC, original submission:

grub-install does not work when --root-directory option is used and the target is the same partition. As workaround it is possible to revert to code from last year just like attached patch.

Kano <kano>

 

Attached Files
file #18348:  15_grub-setup_hotfix.diff added by kano (489B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by fzielcke (Posted a comment)
  • -unavailable- added by robertmh (Posted a comment)
  • -unavailable- added by kano (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 25 Nov 2009 12:44:08 AM UTCrobertmhReleaseNone=>Bazaar - trunk
    Sat 04 Jul 2009 08:08:00 PM UTCrobertmhOpen/ClosedOpen=>Closed
    Tue 30 Jun 2009 10:54:15 PM UTCkanoAttached File-=>Added 15_grub-setup_hotfix.diff, #18348

    Back to the top


    Powered by Savane 3.1-cleanup1