bugGNU Wget - Bugs: bug #26870, FTP retry may use wrong REST value...

 
 

bug #26870: FTP retry may use wrong REST value in some circumstances

Submitted by:  Micah Cowan <micahcowan>
Submitted on:  Mon 22 Jun 2009 05:31:11 PM UTC  
 
Category: Program LogicSeverity: 4 - Important
Priority: 6Status: Fixed
Privacy: PublicAssigned to: None
Originator Name: Open/Closed: Closed
Release: 1.11.4Operating System: None
Reproducibility: NoneFixed Release: None
Planned Release: 1.12Regression: No
Work Required: 0 - HoursPatch Included: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 07 Sep 2009 03:16:55 AM UTC, comment #4:

Fixed in 003eefb66638

Micah Cowan <micahcowan>
Mon 22 Jun 2009 06:12:19 PM UTC, comment #3:

(Er, sorry, brainfart... possible, but unlikely, since the fix should be relatively simple. The hardest part is likely to be the regression test.)

Micah Cowan <micahcowan>
Mon 22 Jun 2009 06:08:58 PM UTC, comment #2:

Since this doesn't appear to be a regression, might potentially punt this for after 1.12 release?

Micah Cowan <micahcowan>
Mon 22 Jun 2009 06:07:28 PM UTC, comment #1:

Looks to me like ftp_loop_internal passes the "expected" length to getftp by pointer, and expects back the downloaded bytecount back from the same var. Naturally, getftp doesn't appear to set this in the case of an interrupted retrieval. Was this ever working?

...There are a lot of returns from getftp, it's probably pointless to try to catch all the right ones. Perhaps better to save away len (looks like we already do that), then set len to 0 immediately, and only set it to something appropriate when we know what we've downloaded.

Micah Cowan <micahcowan>
Mon 22 Jun 2009 05:31:11 PM UTC, original submission:

http://article.gmane.org/gmane.comp.web.wget.general/8757

Micah Cowan <micahcowan>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by micahcowan (Submitted the item)
  • -unavailable- added by micahcowan (Original reporter)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 07 Sep 2009 03:16:55 AM UTCmicahcowanStatusConfirmed=>Fixed
      Open/ClosedOpen=>Closed
    Mon 22 Jun 2009 06:12:19 PM UTCmicahcowanPriority5 - Normal=>6
      RegressionNone=>No
      Work Required1 - Days=>0 - Hours
    Mon 22 Jun 2009 06:07:28 PM UTCmicahcowanStatusNeeds Investigation=>Confirmed
    Mon 22 Jun 2009 05:31:11 PM UTCmicahcowanCarbon-Copy-=>Added -unavailable-

    Back to the top


    Powered by Savane 3.1-cleanup1