bugGNU Wget - Bugs: bug #26792, build_info.c has a risk of...

 
 

bug #26792: build_info.c has a risk of typos/inconsistency

Submitted by:  Micah Cowan <micahcowan>
Submitted on:  Fri 12 Jun 2009 08:25:53 PM UTC  
 
Category: Code ArchitectureSeverity: 2 - Minor
Priority: 4Status: Fixed
Privacy: PublicAssigned to: None
Originator Name: Open/Closed: Closed
Release: NoneOperating System: None
Reproducibility: NoneFixed Release: None
Planned Release: 1.12Regression: None
Work Required: 0 - HoursPatch Included: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 06 Jul 2009 07:07:47 PM UTC, comment #1:

Automatic generation of build_info.c added in 20bda56ffb94.

Steven Schubiger <schubiger>
Project Member
Fri 12 Jun 2009 08:25:53 PM UTC, original submission:

The way build_info.c currently exists, with duplicated strings with alternate "-" or "+", invites the risk that adding a new pair of on/off feature strings can result in typos that would complicate feature-testing. For instance, if one were adding a feature named "skub", one might accidentally add:

Resulting in the ability to correctly test for the presence of the feature, but not its absence.

It would be better if build_info.c were automatically generated from a list of features and how to test for them, to avoid this potential problem.

Micah Cowan <micahcowan>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by schubiger (Posted a comment)
  • -unavailable- added by micahcowan (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 06 Jul 2009 07:07:47 PM UTCschubigerStatusConfirmed=>Fixed
      Open/ClosedOpen=>Closed
    Fri 12 Jun 2009 08:26:15 PM UTCmicahcowanPriority5 - Normal=>4

    Back to the top


    Powered by Savane 3.1-cleanup1