bugGnash - The GNU Flash player - Bugs: bug #26646, Unreachable condition in the...

 
 

bug #26646: Unreachable condition in the libnet/network.cpp

Submitted by:  Ching yi, Chan <qrtt1>
Submitted on:  Sat 23 May 2009 06:56:22 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Release: trunkStatus: Invalid
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 23 May 2009 12:45:19 PM UTC, comment #1:

The code is ok. My submition is wrong. please close this issue.

Ching yi, Chan <qrtt1>
Sat 23 May 2009 06:56:22 AM UTC, original submission:

qrtt1@debian:~/temp/trunk$ bzr revno
10907

By tracing the network.cpp can find the unreachable condition between 607 and 626 lines:

if (ret > 0) {
ret = ::connect(_sockfd, reinterpret_cast<struct sockaddr *>(&sock_in), sizeof(sock_in));
if (ret == 0) {
char *ascip = ::inet_ntoa(sock_in.sin_addr);
// char ascip[INET_ADDRSTRLEN];
// inet_ntop(sock_in.sin_family, &sock_in.sin_addr.s_addr, ascip, INET_ADDRSTRLEN);
log_debug(_("\tport %d at IP %s for fd %d"), port,
ascip, _sockfd);
_connected = true;
assert(_sockfd > 0);
return true;
}
if (ret == -1) {
log_error(_("The connect() socket for fd %d never was available for writing"),
_sockfd);
_sockfd = -1;
assert(!_connected);
return false;
}
}

Ching yi, Chan <qrtt1>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bjacques (Updated the item)
  • -unavailable- added by qrtt1 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 23 May 2009 01:27:44 PM UTCbjacquesStatusNone=>Invalid
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1