bugGNU Screen - Bugs: bug #26401, failed write ACL causes all...

 
 

bug #26401: failed write ACL causes all attached displays to ring bell

Submitted by:  Kees Cook <keescook>
Submitted on:  Wed 29 Apr 2009 06:40:39 PM UTC  
 
Category: User InterfaceSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: ClosedRelease: 4.0.3
Fixed Release: 4.1.0Planned Release: None
Work Required: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 20 Dec 2009 02:03:06 AM UTC, comment #1:

Thanks! Committed and pushed (84b8ef5de3aa94d6b49e81fe4562694fb12c5d0a).

Sadrul Habib Chowdhury <sadrul>
Project Administrator
Wed 29 Apr 2009 06:40:39 PM UTC, original submission:

If several people are attached to a multi-user screen session and the are in read-only mode, each time they press a key, all attached screens will ring the bell. The code causing this is in window.c:

/* XXX FIXME only display !*/
WBell(fore, visual_bell);

I would like to propose using Msg() instead, to mimic the behavior seen for disallowed screen commands seen in process.c:

Msg(0, "write: permission denied (user %s)", D_user->u_name);

Patch attached.

Kees Cook <keescook>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #18055:  59-no-beep-on-write-acl.dpatch added by keescook (812B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by sadrul (Posted a comment)
  • -unavailable- added by keescook (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 20 Dec 2009 02:03:06 AM UTCsadrulStatusNone=>Fixed
      Open/ClosedOpen=>Closed
      Fixed ReleaseNone=>4.1.0
    Wed 29 Apr 2009 06:40:39 PM UTCkeescookAttached File-=>Added 59-no-beep-on-write-acl.dpatch, #18055

    Back to the top


    Powered by Savane 3.1-cleanup1