bugGNUstep - Bugs: bug #26107, [NSURLConnection...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #26107: [NSURLConnection sendSynchronousRequest:returningResponse:error:] is broken

Submitted by:  Doug Simons <theeggcamefirst>
Submitted on:  Tue 07 Apr 2009 03:51:52 PM UTC  
 
Category: Base/FoundationSeverity: 3 - Normal
Item Group: BugStatus: Fixed
Privacy: PublicAssigned to: Gregory John Casamento <gcasa>
Open/Closed: Closed

Wed 16 Jun 2010 08:12:32 AM UTC, comment #2:

Closing this as there are no reports of problems since the fix was applied two months ago.

Richard Frith-Macdonald <CaS>
Project Member
Sat 18 Apr 2009 02:22:29 PM UTC, comment #1:

Doug submitted these patches to me in an email with this:

"Here are the patches I made to get NSURLConnection's +sendSynchronousRequest:returningResponse:error: method to work (see GS bug #26107). I hereby place this code in the public domain and grant full permission to use this code in GNUstep"

he has an assignment in process with the FSF at the moment.

I have gone ahead and committed this after testing them.

GC

Gregory John Casamento <gcasa>
Project AdministratorIn charge of this item.
Tue 07 Apr 2009 03:51:52 PM UTC, original submission:

It appears that this method will simply throw an exception every time. Here is my gdb log:

Breakpoint 6, +[NSURLConnection(NSURLConnectionSynchronousLoading) sendSynchronousRequest:returningResponse:error:] (self=0xb7b179a0, _cmd=0x81c45b0, request=0x8f68020, response=0xbfcb064c, error=0xbfcb0648)
at NSURLConnection.m:292
292 NSData *data = nil;
(gdb) n
294 if ([self canHandleRequest: request] == YES)
(gdb) s
+[NSURLConnection canHandleRequest:] (self=0xb7b179a0, _cmd=0xb7b17bf8, request=0x8f68020)
at NSURLConnection.m:178
178 return [NSURLProtocol canInitWithRequest: request];
(gdb) s
+[NSURLProtocol(Subclassing) canInitWithRequest:] (self=0xb7b1b420, _cmd=0xb7b17b90, request=0x8f68020)
at NSURLProtocol.m:476
476 [self subclassResponsibility: _cmd];
(gdb) s
-[NSObject(GSCategories) subclassResponsibility:] (self=0xb7b1b420, _cmd=0xb7b1b708, aSel=0xb7b17b90)
at GSCategories.m:1078
1078 [NSException raise: NSInvalidArgumentException

Doug Simons <theeggcamefirst>

 

Attached Files
file #17946:  NSURLConnectionPatch added by gcasa (1KiB - application/octet-stream - Patches for connection and URL classes from doug.)
file #17947:  NSURLProtocolPatch added by gcasa (698B - application/octet-stream - Patches for connection and URL classes from doug.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by CaS (Posted a comment)
  • -unavailable- added by gcasa (Updated the item)
  • -unavailable- added by theeggcamefirst (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 16 Jun 2010 08:12:31 AM UTCCaSOpen/ClosedIn Test=>Closed
    Sat 18 Apr 2009 02:22:29 PM UTCgcasaStatusNone=>Fixed
      Assigned toNone=>gcasa
      Open/ClosedOpen=>In Test
    Sat 18 Apr 2009 02:20:06 PM UTCgcasaAttached File-=>Added NSURLConnectionPatch, #17946
      Attached File-=>Added NSURLProtocolPatch, #17947

    Back to the top


    Powered by Savane 3.1-cleanup1