bugcgicc - Bugs: bug #26003, CgiEnvironment getenv

 
 

bug #26003: CgiEnvironment getenv

Submitted by:  None
Submitted on:  Thu 26 Mar 2009 06:23:22 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: sebastien diaz <sebdiaz>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 26 Mar 2009 06:23:22 AM UTC, original submission:

In CgiEnvironment.cpp: void cgicc::CgiEnvironment::readEnvironmentVariables(CgiInput *input)
there's the following code section

>>>>

#ifdef WIN32
// Win32 bug fix by Peter Goedtkindt
std::string https = input->getenv("HTTPS");
if(stringsAreEqual(https, "on"))
fUsingHTTPS = true;
else
fUsingHTTPS = false;
#else
fUsingHTTPS = (getenv("HTTPS") != 0);
#endif

>>>>

then, if i use an non-default IO stream (eg. fastcgi) on linux platform, getenv("HTTPS") will read process context environment.That will not work property.
Maybe input->getenv("HTTPS") looks a better way +_+

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 3 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sat 14 Nov 2009 04:28:04 PM UTCsebdiazOpen/ClosedOpen=>Closed
  StatusNone=>Fixed
Mon 15 Jun 2009 07:08:20 PM UTCsebdiazAssigned toNone=>sebdiaz

Back to the top


Powered by Savane 3.1-cleanup1