bugGuile - Bugs: bug #25865, scm_take_locale_symboln doesn't...

 
 

bug #25865: scm_take_locale_symboln doesn't intern the symbol that it creates

Submitted by:  Neil Jerram <ossau>
Submitted on:  Sat 14 Mar 2009 05:37:10 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: None
Privacy: PublicAssigned to: Ludovic Courtès <civodul>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 19 Mar 2009 09:25:10 PM UTC, comment #2:

Fixed:

http://git.savannah.gnu.org/gitweb/?p=guile.git;a=commitdiff;h=8760f4694dcc8597bb72644d8a1ca1fdf18029a2

and

http://git.savannah.gnu.org/gitweb/?p=guile.git;a=commitdiff;h=05588a1acea43792f33ea632af0d316e847fa9db

Ludovic Courtès <civodul>
Project AdministratorIn charge of this item.
Wed 18 Mar 2009 09:44:43 PM UTC, comment #1:

Hello!

I've come up with the following patch, which also refactorizes duplciated bits. I'll commit it if there's no objection.

Thanks,
Ludo'.

(file #17730)

Ludovic Courtès <civodul>
Project AdministratorIn charge of this item.
Sat 14 Mar 2009 05:37:10 PM UTC, original submission:

This is inferred from code reading.

The doc for scm_take_locale_symboln says:

"Like @code{scm_from_locale_symbol} and @code{scm_from_locale_symboln},
respectively, but also frees @var{str} with @code{free} eventually."

scm_from_locale_symboln creates an interned symbol, so it follows that scm_take_locale_symboln should too. But the relevant code is

scm_take_locale_symboln
-> scm_i_c_take_symbol
-> creates a symbol but doesn't intern it.

Neil Jerram <ossau>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17730:  0001-Have-scm_take_locale_symbol-return-an-interned.patch added by civodul (9KiB - application/octet-stream - The patch against `master')

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by civodul (Updated the item)
  • -unavailable- added by ossau (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 19 Mar 2009 09:25:10 PM UTCcivodulOpen/ClosedOpen=>Closed
    Wed 18 Mar 2009 09:44:43 PM UTCcivodulAttached File-=>Added 0001-Have-scm_take_locale_symbol-return-an-interned.patch, #17730
    Wed 18 Mar 2009 08:47:17 PM UTCcivodulAssigned toNone=>civodul

    Back to the top


    Powered by Savane 3.1-cleanup1