bugGnash - The GNU Flash player - Bugs: bug #25777, Gnahs connects to wrong port

 
 

bug #25777: Gnahs connects to wrong port

Submitted by:  Christer Corneliusson <coypu>
Submitted on:  Fri 06 Mar 2009 04:37:31 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Release: trunkStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 14 Apr 2009 11:12:55 AM UTC, comment #3:

Seems fine to me, and no follow up.

Benjamin Wolsey <bwy>
Project Member
Tue 10 Mar 2009 09:39:55 AM UTC, comment #2:

I added focused automated testcases for this issue and committed
a real fix (it was still broken after application of that patch).

The testcase might still missing some corner case so please
Christer, give it a try. Thanks.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 09 Mar 2009 03:56:54 PM UTC, comment #1:

I applied this patch, which works for me. Testing shows the port is now properly stored from the URL.

Rob Savoye <rsavoye>
Project Administrator
Fri 06 Mar 2009 04:37:31 PM UTC, original submission:

If u get a SWF file from a webserver that listens to port 80 its works fine. But if the SWF file needs to get other files (eg get some pictures) it is trying to get this files from port 80.

The following patch does solve the problem, and i havn't noticed that this patch introduces any new bugs.

=== modified file 'libbase/URL.cpp'
--- libbase/URL.cpp 2009-02-25 22:33:03 +0000
+++ libbase/URL.cpp 2009-03-06 16:18:13 +0000
@@ -294,6 +294,8 @@
// Extract the port number from the hostname, if any
split_port_from_host();

+ _port= baseurl._port;
+
split_querystring_from_path();

normalize_path(_path);

Christer Corneliusson <coypu>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bwy (Posted a comment)
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by rsavoye (Posted a comment)
  • -unavailable- added by coypu (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 14 Apr 2009 11:12:55 AM UTCbwyStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Tue 10 Mar 2009 09:39:55 AM UTCstrkAssigned torsavoye=>strk
    Mon 09 Mar 2009 03:56:54 PM UTCrsavoyeStatusNone=>Ready For Test
      Assigned toNone=>rsavoye

    Back to the top


    Powered by Savane 3.1-cleanup1