bugDenemo - Bugs: bug #25724, patch to avoid crash when a staff...

 
 

bug #25724: patch to avoid crash when a staff is deleted

Submitted by:  None
Submitted on:  Sat 28 Feb 2009 07:31:47 AM UTC  
 
Category: NoneSeverity: 4 - Important
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Richard Shann <rshann>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 28 Feb 2009 09:29:46 AM UTC, comment #1:

Fixing in draw.c has the disadvantage that draw may not be called (e.g. in scripts). I have fixed it in the scroll bar code. Thank you for drawing attention to this important bug - how long has it been there I wonder? It was sensitive to the size of the window you are using, so perhaps people used larger windows to see all the staffs at once.

Richard Shann <rshann>
Project AdministratorIn charge of this item.
Sat 28 Feb 2009 07:31:47 AM UTC, original submission:

I added a call to set_bottom_staff() in draw_score in draw.c
to avoid crash when I delete a staff from a score.

I found si->bottom_staff is not taken care of after deletestaff() is called.

Though I don't know this is right place to put the call to set_bottom_staff()
now I don't see the crash after I delete a staff from a score.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17546:  02set_bottom_staff_before_draw.patch added by None (330B - text/x-diff - This patch is for Denemo release 0.8.2 and git 20092727.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rshann (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 28 Feb 2009 09:29:46 AM UTCrshannSeverity3 - Normal=>4 - Important
      StatusNone=>Fixed
      Assigned toNone=>rshann
      Open/ClosedOpen=>Closed
    Sat 28 Feb 2009 07:31:47 AM UTCNoneAttached File-=>Added 02set_bottom_staff_before_draw.patch, #17546

    Back to the top


    Powered by Savane 3.1-cleanup1