bugGnash - The GNU Flash player - Bugs: bug #25638, 15 failures in test_rtmp

 
 

bug #25638: 15 failures in test_rtmp

Submitted by:  Benjamin Wolsey <bwy>
Submitted on:  Thu 19 Feb 2009 09:55:53 AM UTC  
 
Category: testsuiteSeverity: 6 - Security
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Rob Savoye <rsavoye>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 19 Feb 2009 06:28:22 PM UTC, comment #2:

There was a change in the number of elements returned when decoding some messages that broke most of the test cases. This has now been fixed in trunk and the release branch.

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Thu 19 Feb 2009 02:07:24 PM UTC, comment #1:

The test case itself is no bogus, as the API is was testing has changed. I'm planning on fixing it for the release, but might just disable the test case, as they're primarily for the client side of the API.

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Thu 19 Feb 2009 09:55:53 AM UTC, original submission:

I haven't looked at all of these. On line 805 there is a memory error as a buffer size of 42 is allocated, whereas hex2mem creates a buffer of size 45 (3 type header bytes?), and memcmp uses this size to compare the buffers (though the test still passes).

These are the failures for me on Mandriva (x86_64):

FAIL: test_rtmp: Encoded RTMP header(size 4)
FAIL: test_rtmp: Encoded RTMPClient::encodeStreamOp(RTMP::STREAM_PLAY)
FAIL: test_rtmp: Encoded RTMPClient::encodeStreamOp(RTMP::STREAM_PAUSE)
FAIL: test_rtmp: Encoded RTMPClient::encodeStream(RTMP::SEEK)
FAIL: test_rtmp: Encoded RTMPClient::encodeStream(RTMP::SEEK, double)
FAIL: test_rtmp: Decoded RTMP Result(NC_CONNECT_SUCCESS) message
FAIL: test_rtmp: Decoded RTMP result(NC_CONNECT_FAILED(as result)
FAIL: test_rtmp: Encoded/Decoded RTMP onStatus(Play Reset)
FAIL: test_rtmp: Encoded/Decoded RTMP onStatus(Play Start)
FAIL: test_rtmp: Decoded RTMP _error(NC_CONNECT_REJECTED)
FAIL: test_rtmp: Encoded/Decoded RTMP onStatus(Play Stream Not Found)
FAIL: test_rtmp: Encoded/Decoded RTMP onStatus(Play Stream Stop)
FAIL: test_rtmp: RTMP::split(2 packets size)
FAIL: test_rtmp: RTMP::split(5 packets)
FAIL: test_rtmp: RTMP::split(corrupted packets)

and Lenny (i585):

FAIL: test_rtmp: Encoded RTMP header(size 4)
FAIL: test_rtmp: Encoded RTMPClient::encodeStreamOp(RTMP::STREAM_PLAY)
FAIL: test_rtmp: Encoded RTMPClient::encodeStreamOp(RTMP::STREAM_STOP)
FAIL: test_rtmp: Decoded RTMP Result(NC_CONNECT_SUCCESS) message
FAIL: test_rtmp: Decoded RTMP result(NC_CONNECT_FAILED(as result)
FAIL: test_rtmp: Encoded/Decoded RTMP onStatus(Play Reset)
FAIL: test_rtmp: Encoded/Decoded RTMP onStatus(Play Start)
FAIL: test_rtmp: Decoded RTMP _error(NC_CONNECT_REJECTED)
FAIL: test_rtmp: Encoded/Decoded RTMP onStatus(Play Stream Not Found)
FAIL: test_rtmp: Encoded/Decoded RTMP onStatus(Play Stream Stop)
FAIL: test_rtmp: RTMP::split(2 packets size)
FAIL: test_rtmp: RTMP::split(5 packets)
FAIL: test_rtmp: RTMP::split(corrupted packets)

Benjamin Wolsey <bwy>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rsavoye (Posted a comment)
  • -unavailable- added by bwy (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 20 Feb 2009 08:49:31 AM UTCbwyStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Thu 19 Feb 2009 06:28:22 PM UTCrsavoyeStatusNone=>Ready For Test
    Thu 19 Feb 2009 02:07:24 PM UTCrsavoyeCategoryNone=>testsuite
      Assigned toNone=>rsavoye

    Back to the top


    Powered by Savane 3.1-cleanup1