bugGNUstep - Bugs: bug #25587, tables not always disappear from...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #25587: tables not always disappear from outline view when deleted

Submitted by:  Sebastian Reitenbach <buzzdee>
Submitted on:  Sat 14 Feb 2009 02:58:34 PM UTC  
 
Category: gdl2Severity: 3 - Normal
Item Group: BugStatus: Fixed
Privacy: PublicAssigned to: David Ayers <ayers>
Open/Closed: Closed

Wed 25 Feb 2009 09:03:09 AM UTC, comment #4:

OK. Since the NSUndoManager behavior has changed, I committed a fix to EOEditingContext which should insure the processing isn't invoked prematurely.

David Ayers <ayers>
Project MemberIn charge of this item.
Tue 17 Feb 2009 01:51:56 PM UTC, comment #3:

I know I argued that we should be defensive and leave the workaround privately, but I'm swaying...

_undoManagerCheckpoint: will be called on each undo grouping except for the first one (now after the fix to NSUndoManager). But we are processing changes directly on begin and end groupings, and the bug was that the changes had not actually propagated yet.

On the one hand I think it may be more efficient to simply register via _enqueueEndOfEventNotification (except for the case that we are called by that method).

Maybe we should spend some time with WO4.5 to find out when the checkpoint notifications actually cause the editing context to process it's changes. (And probably develop some test cases.)

So for now maybe revert and add a TODO... something like:
Figure out when checkpoint notifications should cause the editing context to process changes.

David Ayers <ayers>
Project MemberIn charge of this item.
Tue 17 Feb 2009 01:02:22 PM UTC, comment #2:

i've commited a workaround to gdl2 for this which should fix this bug, i'm not convinced of either the workarounds correctness or incorrectness, so if anyone has an opinion either way it would be most appreciated,

the bug in base which this stems from has also been fixed, and the original gdl2 code now works again, but the workaround works with both vesions so unless there is an argument against it i'll consider leaving it there i suppose :)

matt rice <ratmice>
Project Member
Tue 17 Feb 2009 09:18:44 AM UTC, comment #1:

thanks for the report i can reproduce this and will look into it.

matt rice <ratmice>
Project Member
Sat 14 Feb 2009 02:58:34 PM UTC, original submission:

checked out gnustep-gdl2 from svn revision 27860.
when deleting properties from the model, then they sometimes only disappear in the table view, but not on the left in the outline view.

In cases when this happens, I see the following on the console:
2009-02-14 15:50:33.475 DBModeler[18906] Problem posting notification: <NSException: 0x7ee58fe8> NAME:NSInvalidArgumentException REASON:Tried to insert nil to array INFO:{Array = (("{className = EOGenericRecord; name = Entity; relationships = (); }")); Index = 0; }

when afterwards deleting another table, then both will disappear from the left outline view.

libffi-3.0.8
gnustep-make-2.0.8
gnustep-base-1.18.0p0
gnustep-back-0.16.0
gnustep-gui-0.16.0
gnustep-renaissance-0.8.0
gnustep-gorm-1.2.8
on OpenBSD 4.4. i386.

Sebastian Reitenbach <buzzdee>
Project Member

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by ayers (Posted a comment)
  • -unavailable- added by ratmice (Posted a comment)
  • -unavailable- added by buzzdee (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 25 Feb 2009 09:03:09 AM UTCayersStatusConfirmed=>Fixed
      Assigned toNone=>ayers
      Open/ClosedOpen=>Closed
    Tue 17 Feb 2009 09:18:44 AM UTCratmiceStatusNone=>Confirmed

    Back to the top


    Powered by Savane 3.1-cleanup1