bugGnash - The GNU Flash player - Bugs: bug #25500, Cygnal fails to compile in trunk

 
 

bug #25500: Cygnal fails to compile in trunk

Submitted by:  Bernhard Rosenkraenzer <bero>
Submitted on:  Thu 05 Feb 2009 04:16:55 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Rob Savoye <rsavoye>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 27 Feb 2009 05:02:35 PM UTC, comment #5:

Applied, thanks. Cygnal now builds fine for me with visibility enabled. Please report back if you still have problems.

Benjamin Wolsey <bwy>
Project Member
Fri 27 Feb 2009 03:20:19 PM UTC, comment #4:

My patch is still needed -- actually more than the patch is needed now.

If the compiler flag -fvisibility=hidden is used, current trunk fails with

cygnal.o: In function `global constructors keyed to act1':
cygnal.cpp:(.text+0xcd): undefined reference to `gnash::Cache::getDefaultInstance()'
cygnal.o: In function `admin_handler(gnash::Network::thread_params_t*)':
cygnal.cpp:(.text+0xc31): undefined reference to `gnash::Cache::stats(bool) const'
cygnal.o: In function `connection_handler(gnash::Network::thread_params_t*)':
cygnal.cpp:(.text+0x1a94): undefined reference to `http_handler'
cygnal.cpp:(.text+0x1aab): undefined reference to `http_handler'
rtmp_server.o: In function `global constructors keyed to _ZN6cygnal10RTMPServerC2Ev':
rtmp_server.cpp:(.text+0x56): undefined reference to `gnash::Cache::getDefaultInstance()'
rtmp_server.o: In function `cygnal::RTMPServer::sendFile(int, std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)':
rtmp_server.cpp:(.text+0x1350): undefined reference to `gnash::Cache::findFile(std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
rtmp_server.cpp:(.text+0x146e): undefined reference to `gnash::DiskStream::loadToMem(unsigned int, long)'
rtmp_server.cpp:(.text+0x14d5): undefined reference to `gnash::DiskStream::close()'
rtmp_server.cpp:(.text+0x1632): undefined reference to `gnash::DiskStream::DiskStream()'
rtmp_server.cpp:(.text+0x169e): undefined reference to `gnash::DiskStream::open(std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
rtmp_server.cpp:(.text+0x176e): undefined reference to `gnash::DiskStream::loadToMem(long)'
rtmp_server.cpp:(.text+0x17e0): undefined reference to `gnash::Cache::addPath(std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
rtmp_server.o: In function `void boost::checked_delete<gnash::DiskStream>(gnash::DiskStream*)':
rtmp_server.cpp:(.text._ZN5boost14checked_deleteIN5gnash10DiskStreamEEEvPT_[void boost::checked_delete<gnash::DiskStream>(gnash::DiskStream*)]+0x10): undefined reference to `gnash::DiskStream::~DiskStream()'
rtmp_server.o: In function `boost::detail::sp_counted_impl_p<gnash::DiskStream>::dispose()':
rtmp_server.cpp:(.text._ZN5boost6detail17sp_counted_impl_pIN5gnash10DiskStreamEE7disposeEv[boost::detail::sp_counted_impl_p<gnash::DiskStream>::dispose()]+0x13): undefined reference to `gnash::DiskStream::~DiskStream()'
collect2: ld returned 1 exit status
make[3]: *** [cygnal] Error 1

I'll attach an updated patch that fixes it for current trunk

Bernhard Rosenkraenzer <bero>
Mon 23 Feb 2009 09:24:21 PM UTC, comment #3:

The rtmp branch was migrated to trunk recently, and builds fine for me.

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Thu 05 Feb 2009 04:25:59 PM UTC, comment #2:

The problem is with a missing visibility declaration in libnet and as such will not show up in older gcc versions - please make sure the fix (attached) or something equivalent gets in at least after the rtmp merge.

Bernhard Rosenkraenzer <bero>
Thu 05 Feb 2009 04:19:37 PM UTC, comment #1:

Most of the work on Cygnal is in the 'rtmp' branch, and will be migrated to trunk for the next release in about a week. So rather than fix this bug now, it'll get fixed when that is done. Cygnal has been undergoing a huge amount of work lately.

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Thu 05 Feb 2009 04:16:55 PM UTC, original submission:

cygnal.o: In function `global constructors keyed to act1':
cygnal.cpp:(.text+0xcd): undefined reference to `gnash::Cache::getDefaultInstance()'
cygnal.o: In function `admin_handler(gnash::Network::thread_params_t*)':
cygnal.cpp:(.text+0xbe1): undefined reference to `gnash::Cache::stats(bool) const'
cygnal.o: In function `connection_handler(gnash::Network::thread_params_t*)':
cygnal.cpp:(.text+0x1484): undefined reference to `http_handler'
cygnal.cpp:(.text+0x149b): undefined reference to `http_handler'
collect2: ld returned 1 exit status
make[3]: *** [cygnal] Error 1

Bernhard Rosenkraenzer <bero>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17542:  gnash-visibility.patch added by bero (1KiB - text/x-patch - Updated patch for current trunk)
file #17408:  gnash-visibility.patch added by bero (619B - text/x-patch - Fix)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bwy (Posted a comment)
  • -unavailable- added by rsavoye (Posted a comment)
  • -unavailable- added by bero (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 27 Feb 2009 05:02:35 PM UTCbwyStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Fri 27 Feb 2009 03:21:35 PM UTCberoAttached File-=>Added gnash-visibility.patch, #17542
    Mon 23 Feb 2009 09:24:21 PM UTCrsavoyeStatusPostponed=>Ready For Test
    Thu 05 Feb 2009 04:24:40 PM UTCberoAttached File-=>Added gnash-visibility.patch, #17408
    Thu 05 Feb 2009 04:19:37 PM UTCrsavoyeStatusNone=>Postponed
      Assigned toNone=>rsavoye

    Back to the top


    Powered by Savane 3.1-cleanup1