bugGnash - The GNU Flash player - Bugs: bug #25499, Bogus liblber dependency

 
 

bug #25499: Bogus liblber dependency

Submitted by:  Bernhard Rosenkraenzer <bero>
Submitted on:  Thu 05 Feb 2009 03:32:49 PM UTC  
 
Category: buildSeverity: 3 - Normal
Release: masterStatus: Fixed
Privacy: PublicAssigned to: Bastiaan Jacques <bjacques>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri 01 Apr 2011 11:39:44 PM UTC, comment #8:

Fixed in cdcc7e11fd940e72be0845775e212ae5f3eb6409.

Bastiaan Jacques <bjacques>
Project MemberIn charge of this item.
Sat 19 Mar 2011 06:35:26 PM UTC, comment #7:

Seeing as the bug is the extra dependency, and it is acknowledged, this is confirmed rather than WFM.

Bastiaan Jacques <bjacques>
Project MemberIn charge of this item.
Sun 13 Mar 2011 03:09:35 PM UTC, comment #6:

This was added for Ubuntu, which had a dependency on this library in one of the dependencies Gnash needed. So for several Ubuntu releases, Gnash wouldn't link without this. I'd be way careful removing things like this without serious testing. Chances are the bad package dependency in Ubuntu has been fixed, this was several years ago.

Rob Savoye <rsavoye>
Project Administrator
Sun 13 Mar 2011 02:42:31 PM UTC, comment #5:

The AC_CHECK_LIB call was added again in ad173a141187cbfd178ffb37c325de671f64d99b.

Bastiaan Jacques <bjacques>
Project MemberIn charge of this item.
Fri 20 Feb 2009 08:53:36 AM UTC, comment #4:

It's commented out in configure.ac now (commit 10598), though not mentioned in the commit message, so might not have been intended for commit. Either way, it's gone at the moment.

Benjamin Wolsey <bwy>
Project Member
Thu 05 Feb 2009 04:50:29 PM UTC, comment #3:

It was a quick hack to get the release out the door, but yes, this is likely a bogus dependency, and should be removed. As the next release process starts in a week, I'll see about testing and fixing this then while I'm doing other config & build hacking.

Rob Savoye <rsavoye>
Project Administrator
Thu 05 Feb 2009 04:33:07 PM UTC, comment #2:

Please don't punish users of other distributions for Ubuntu's bugs...

A workaround like this should check for the problem instead of being applied unconditionally. Here (on Ark Linux, and quite probably most other non-Ubuntu OSes) nothing gnash uses requires liblber.

Bernhard Rosenkraenzer <bero>
Thu 05 Feb 2009 03:44:58 PM UTC, comment #1:

Actually I added this library check because one of the dependant libraries on Ubuntu Hardy needed this, and didn't have it listed as a dependency for that library, so Gnash wouldn't link. I can try again on Intrepid and see if it's still a problem.

Rob Savoye <rsavoye>
Project Administrator
Thu 05 Feb 2009 03:32:49 PM UTC, original submission:

If built on a system that has liblber installed, gnash links to it without making use of any of its functions, introducing an unnecessary dependency.

It is caused by the

AC_CHECK_LIB(lber, ber_free)

line in configure.ac, which doesn't seem to serve any purpose.

Bernhard Rosenkraenzer <bero>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17407:  gnash-no-bogus-lber-dep.patch added by bero (409B - text/x-patch - Fix)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bjacques (Posted a comment)
  • -unavailable- added by bwy (Posted a comment)
  • -unavailable- added by rsavoye (Posted a comment)
  • -unavailable- added by bero (Submitted the item)
  • -unavailable- added by bero
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 13 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 01 Apr 2011 11:39:44 PM UTCbjacquesStatusConfirmed=>Fixed
      Assigned torsavoye=>bjacques
      Open/ClosedOpen=>Closed
    Sat 19 Mar 2011 06:35:25 PM UTCbjacquesStatusWorks For Me=>Confirmed
    Sun 13 Mar 2011 03:09:35 PM UTCrsavoyeStatusConfirmed=>Works For Me
    Sun 13 Mar 2011 02:42:31 PM UTCbjacquesCategorycore=>build
      Releasetrunk=>master
      StatusReady For Test=>Confirmed
    Fri 20 Feb 2009 08:53:36 AM UTCbwyStatusPostponed=>Ready For Test
    Thu 05 Feb 2009 04:50:29 PM UTCrsavoyeStatusNone=>Postponed
      Assigned toNone=>rsavoye
    Thu 05 Feb 2009 03:32:49 PM UTCberoAttached File-=>Added gnash-no-bogus-lber-dep.patch, #17407
      Carbon-Copy-=>Added -unavailable-

    Back to the top


    Powered by Savane 3.1-cleanup1