bugGNUstep - Bugs: bug #25447, NSPreferencePane Cocoa...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #25447: NSPreferencePane Cocoa compatibility broken

Submitted by:  Doug Simons <theeggcamefirst>
Submitted on:  Sat 31 Jan 2009 12:16:47 AM UTC  
 
Category: Gui/AppKitSeverity: 3 - Normal
Item Group: BugStatus: Fixed
Privacy: PublicAssigned to: Gregory John Casamento <gcasa>
Open/Closed: Closed

Sun 01 Feb 2009 09:11:19 PM UTC, comment #4:

It works for me! Thanks.

Doug Simons <theeggcamefirst>
Sun 01 Feb 2009 08:32:26 PM UTC, comment #3:

I removed the whole section of code looking for the CFBundleIdentifier (and non-standard GSBundleIdentifier) values in the dictionary, and replaced it with calls to the standard [NSBundle-bundleIdentifier] method.

I also changed the other usage of non-standard keys I found.

I guess there's some historical reason why this code contained all its own non-standard handling of the Info.plist file, but I really doubt there's any reason it shouldn't behave the same way as the rest of GNUstep (and Cocoa) now.

Richard Frith-Macdonald <CaS>
Project Member
Sun 01 Feb 2009 04:45:11 PM UTC, comment #2:

That only takes care of part of the problem. The logic got shifted around recently, such that the code to read CFBundleIdentifier when identstr is nil needs to be moved up a few lines so it comes right after reading GSBundleIdentifier. If you could move that code we'll be in good shape.

Doug Simons <theeggcamefirst>
Sat 31 Jan 2009 01:53:25 AM UTC, comment #1:

I have remoced the non-standard checks from the framework, please test it again and see if it works.

Thanks, GC

Gregory John Casamento <gcasa>
Project AdministratorIn charge of this item.
Sat 31 Jan 2009 12:16:47 AM UTC, original submission:

I just discovered that the latest change to NSPreferencePane.m (revisions 27570 & 27571) broke compatibility with my preference pane imported from Cocoa.

It's no longer checking in the plist for CFBundleIdentifier when GSBundleIdentifier is not present. Also, it is once again rejecting any plist that doesn't have a GSPrefPaneIconFile key (mine has NSPrefPaneIconFile), GSPrefPaneIconLabel (mine doesn't seem to have any comparable key), and NSExecutable (mine has CFBundleExecutable).

I'd appreciate it if compatibility with Cocoa-style plists could be restored (note that this is for a preference pane within an app, not in System Preferences, in case that has any bearing on the fix). Thanks!

Doug Simons <theeggcamefirst>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by CaS (Posted a comment)
  • -unavailable- added by gcasa (Posted a comment)
  • -unavailable- added by theeggcamefirst (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 11 Feb 2009 08:41:08 AM UTCCaSOpen/ClosedIn Test=>Closed
    Sat 31 Jan 2009 01:53:25 AM UTCgcasaStatusNone=>Fixed
      Assigned toNone=>gcasa
      Open/ClosedOpen=>In Test

    Back to the top


    Powered by Savane 3.1-cleanup1