bugGnash - The GNU Flash player - Bugs: bug #25381, AGG renderer compilation error...

 
 

bug #25381: AGG renderer compilation error (revno 10552)

Submitted by:  Sander Knopper <saknopper>
Submitted on:  Thu 22 Jan 2009 07:51:37 PM UTC  
 
Category: buildSeverity: 3 - Normal
Release: trunkStatus: Fixed
Privacy: PublicAssigned to: Bastiaan Jacques <bjacques>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 22 Jan 2009 09:54:41 PM UTC, comment #6:

Yes, that patch made it work. Thanks for the quick response!

Sander Knopper <saknopper>
Thu 22 Jan 2009 09:39:24 PM UTC, comment #5:

I've committed the patch to trunk. I was able to reproduce the problem (and fix) with GCC4.1 on Ubuntu.

On a side note, why do you think the existing code is nicer than boost::bind?

Bastiaan Jacques <bjacques>
Project MemberIn charge of this item.
Thu 22 Jan 2009 09:36:29 PM UTC, comment #4:

It works for me on a number of compilers, and I can't see any reason why it should be wrong (though I haven't looked at the standard that closely here).

Perhaps it should be raised with the gentoo gcc maintainers (I'd like to know if it's correct or not), but in the interest of compatibility, I suppose we'd better replace a nice bit of code with boost::bind (assuming it works).

Benjamin Wolsey <bwy>
Project Member
Thu 22 Jan 2009 08:29:53 PM UTC, comment #3:

Can you give this patch a try, Sander?

(file #17306)

Bastiaan Jacques <bjacques>
Project MemberIn charge of this item.
Thu 22 Jan 2009 08:24:54 PM UTC, comment #2:

Perhaps this is related to:

http://gcc.gnu.org/ml/libstdc++/2000-06/msg00210.html

And perhaps it can be solved by using boost::bind.

Bastiaan Jacques <bjacques>
Project MemberIn charge of this item.
Thu 22 Jan 2009 08:18:39 PM UTC, comment #1:

Works for me with GCC 4.3.2.

The error from bug starter's log is:

/usr/lib/gcc/x86_64-pc-linux-gnu/4.1.2/include/g++-v4/bits/stl_function.h: At global scope:
/usr/lib/gcc/x86_64-pc-linux-gnu/4.1.2/include/g++-v4/bits/stl_function.h: In instantiation of 'std::binder2nd<std::mem_fun1_ref_t<void, gnash::Path, const gnash::SWFMatrix&> >':
render_handler_agg.cpp:1063: instantiated from 'void gnash::render_handler_agg<PixelFormat>::apply_matrix_to_path(const gnash::<unnamed>::GnashPaths&, gnash::<unnamed>::GnashPaths&, const gnash::SWFMatrix&) [with PixelFormat = agg::pixfmt_alpha_blend_rgba<agg::blender_rgba_pre<agg::rgba8, agg::order_abgr>, agg::row_accessor<unsigned char>, unsigned int>]'
render_handler_agg.cpp:989: instantiated from 'void gnash::render_handler_agg<PixelFormat>::draw_shape_character(gnash::shape_character_def*, const gnash::SWFMatrix&, const gnash::cxform&) [with PixelFormat = agg::pixfmt_alpha_blend_rgba<agg::blender_rgba_pre<agg::rgba8, agg::order_abgr>, agg::row_accessor<unsigned char>, unsigned int>]'
render_handler_agg.cpp:2178: instantiated from here
/usr/lib/gcc/x86_64-pc-linux-gnu/4.1.2/include/g++-v4/bits/stl_function.h:435: error: forming reference to reference type 'const gnash::SWFMatrix&'

Bastiaan Jacques <bjacques>
Project MemberIn charge of this item.
Thu 22 Jan 2009 07:51:37 PM UTC, original submission:

Hi all,

I'm getting a compilation error while compiling the latest version from bazaar (revision 10552) under Gentoo.

The complete build log is attached.

Sander Knopper <saknopper>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17305:  build.log added by saknopper (455KiB - text/x-log)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bwy (Posted a comment)
  • -unavailable- added by bjacques (Posted a comment)
  • -unavailable- added by saknopper (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 23 Jan 2009 09:27:58 AM UTCbwyStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Thu 22 Jan 2009 09:39:24 PM UTCbjacquesStatusNone=>Ready For Test
      Assigned toNone=>bjacques
    Thu 22 Jan 2009 08:29:53 PM UTCbjacquesAttached File-=>Added gnash-gcc4.1-bind2nd-refs.diff, #17306
    Thu 22 Jan 2009 07:54:21 PM UTCsaknopperAttached File-=>Added build.log, #17305

    Back to the top


    Powered by Savane 3.1-cleanup1