bugGNUstep - Bugs: bug #25346, Memory management issues in...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #25346: Memory management issues in NSAnimation

Submitted by:  Richard Frith-Macdonald <CaS>
Submitted on:  Fri 16 Jan 2009 02:09:08 PM UTC  
 
Category: Gui/AppKitSeverity: 3 - Normal
Item Group: BugStatus: Fixed
Privacy: PublicAssigned to: Fred Kiefer <FredKiefer>
Open/Closed: Closed

Mon 20 Jul 2009 11:03:32 AM UTC, comment #5:

Time is up :-)

Fred Kiefer <FredKiefer>
Project MemberIn charge of this item.
Fri 30 Jan 2009 10:14:42 PM UTC, comment #4:

Changed this to testing and I will close this bug report if there isn't any proof for a still exisiting memory issue within a few weeks.

Fred Kiefer <FredKiefer>
Project MemberIn charge of this item.
Mon 19 Jan 2009 05:28:06 PM UTC, comment #3:

I found that the method _gs_startAnimationInOwnLoop could produce a huge amount of NSGDate objects while it was executed. I fixed this be introducing an additional autorelease pool.
Now the only thing that gets leak are some GSMutableArrays and I have no idea where this is happening.

Could you please retest your orignal code to see if things are ok now?

Fred Kiefer <FredKiefer>
Project MemberIn charge of this item.
Mon 19 Jan 2009 02:46:29 PM UTC, comment #2:

More information by Benhur Stein:

Thanks.
It was more than a year ago, I do not recall exactly, but it had somthing to do with the way the animator used timers, there was a retain cycle in there too, but the nsanimator code was too complicated for a quick investigation.
I see that the code has been simplified, maybe the problem I had is gone.
The code I had that used NSAnimator was altered to use timers, and it no longer exists.
I recall however that the problem showed up because it used lots of nsanimators (allocated a new one for each animation, that was released soon after the animation ended).
Sorry for not having more info than that...

Benhur

Fred Kiefer <FredKiefer>
Project MemberIn charge of this item.
Mon 19 Jan 2009 12:18:01 AM UTC, comment #1:

I rsolved the first retain cycle and cleaned up the code in GSAnimator a bit. There still might be some problems in NSAnimation.

Fred Kiefer <FredKiefer>
Project MemberIn charge of this item.
Fri 16 Jan 2009 02:09:08 PM UTC, original submission:

On 16 Jan 2009, at 11:33, Benhur Stein <benhur.stein@gmail.com> wrote:

If someone looks into NSAnimation, it is worth reviewing its memory management.
I tried to use NSAnimation some time ago, and gave up because it was
leaking memory.
I did a quick look at it at the time, and there is a retain cycle
between NSAnimation and
GSAnimator. When I broke this (by removing the retaining of
NSAnimation in GSAnimator),
I just went a bit further until another retain cycle, and I gave up as
I did not have enough time,
and changed my code to not use it. My intention was to come back and
try harder to find
this or at least file a bug report, but I did neither...

So, rather than let the report get lost, I'm adding it the the tracking system

Richard Frith-Macdonald <CaS>
Project Member

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by FredKiefer (Posted a comment)
  • -unavailable- added by CaS (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 20 Jul 2009 11:03:32 AM UTCFredKieferStatusReady For Test=>Fixed
      Open/ClosedIn Test=>Closed
    Fri 30 Jan 2009 10:14:42 PM UTCFredKieferStatusIn Progress=>Ready For Test
      Open/ClosedOpen=>In Test
    Mon 19 Jan 2009 05:28:06 PM UTCFredKieferAssigned toNone=>FredKiefer
    Mon 19 Jan 2009 12:18:01 AM UTCFredKieferStatusNone=>In Progress

    Back to the top


    Powered by Savane 3.1-cleanup1