bugGNUstep - Bugs: bug #25270, -[NSTimer invalidate] should...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #25270: -[NSTimer invalidate] should release target and userInfo, but no longer does

Submitted by:  Larry Campbell <lcampbel>
Submitted on:  Wed 07 Jan 2009 11:46:46 PM UTC  
 
Category: Base/FoundationSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Fri 09 Jan 2009 09:24:57 AM UTC, comment #1:

Thanks ... fixed in svn.

Richard Frith-Macdonald <CaS>
Project Member
Wed 07 Jan 2009 11:46:46 PM UTC, original submission:

Revision 25780 on the svn trunk broke this: -{NSTimer invalidate] should release its target and userInfo, but this code got moved into the dealloc method. This is wrong: Mac OS X documentation clearly states that invalidate releases the target and userInfo; and it's broken: often the target itself owns a reference to the NSTimer, and would rely on invalidate to break the reference count loop.

Larry Campbell <lcampbel>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by CaS (Posted a comment)
  • -unavailable- added by lcampbel (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 09 Jan 2009 09:24:57 AM UTCCaSStatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1