bugGNUstep - Bugs: bug #25258, GNUstep base reconfigures when...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #25258: GNUstep base reconfigures when GNUSTEP_INSTALLATION_DOMAIN=SYSTEM is passed to make install

Submitted by:  Stef <stefanbidi>
Submitted on:  Tue 06 Jan 2009 02:41:22 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Invalid
Privacy: PublicAssigned to: None
Open/Closed: Closed

Tue 06 Jan 2009 12:31:04 PM UTC, comment #5:

I didn't know this was the new/correct behavior for configure and make install. It was a little confusing since it's not what I was used to.

I'll take a look at the stuff in trunk as soon as I'm done generating these install scripts and packages for the new Slackware.

I'll also add that the second "./configure" always spits out an error (but don't stop execution) when trying to move GNUstep.h (I think that's the file, I'm not at home now and check) from Headers/Additions/GNUstepBase since it was already moved by the previous "./configure" run. No big deal since it doesn't error out, it just prints that it could not find GNUstep.h.

Thank you

Stef <stefanbidi>
Project Member
Tue 06 Jan 2009 10:15:42 AM UTC, comment #4:

> I think a correct check would ensure that none of the paths are relative


OK ... thanks ... done in trunk :-)

This is important for me because './configure' is usually executed
as your local user, while 'make install' is usually executed as root.

Having 'make install' create any file, or recompile anything, causes always
a lot of pain and confusion since it creates files or compilation results that
are owned by root and that you can't delete as your local user.

You end up with a project where './configure', 'make', 'make clean',
'make distclean', even a 'rm -Rf directory' all fail unless you first go back
to root and do a 'make distclean' (or 'rm -Rf bad_project').

If a user doesn't know that he has to become root and do a 'make distclean'
(which is more or less obvious depending on your previous Unix/make
experience), he'll be stuck pretty hard. :-(

Anyway, not the end of the world, but it's nice and simple if 'make install'
only installs. :-)

The changes are in trunk and need testing now.

Thanks

Nicola Pero <nico>
Project Member
Tue 06 Jan 2009 09:23:34 AM UTC, comment #3:

I think a correct check would ensure that none of the paths are relative... and checking that looked like more trouble than it was worth. I'd rather spend the time making the process faster ...
eg.
1. factor out the path setup stuff from configure.ac into a subsidiary configuration file.
2. store the results of that configuration in a file used only by NSPathUtilities.m so that we would only recompile that one file.
3. change the main makefile so we only do the minimum work necessary ... which ought to be quick enough that it really doesn't matter if we have to do it at ther poiint when we install.

Richard Frith-Macdonald <CaS>
Project Member
Tue 06 Jan 2009 09:08:18 AM UTC, comment #2:

> The current solution could be improved so that it could avoid reconfiguring if it was
> not using relative paths.


That would be a big improvement since AFAIK nobody is using relative paths
but on MinGW, so the automatic reconfiguration annoys everyone not using
MinGW (most of us) ;-)

I had added a check that prevented the reconfiguration on all systems but
on MinGW but you removed it so I assume we need a more general check ?

Shall we check in configure that the final GNUSTEP_SYSTEM_TOOLS that we
hardcode in gnustep-base starts with a '/' ? If it does, we turn off auto-
reconfiguration, if not, we turn it on ? I can do this change pretty quickly
- if we agree it's the right change. ;-)

Thanks

Nicola Pero <nico>
Project Member
Tue 06 Jan 2009 04:30:38 AM UTC, comment #1:

This is the correct behavior ... if the library was previously configured to install in a different domain (and the local domain is the default).
Base needs to be installed into the domain it was built for, in case it is finding paths relative to its installation domain.

The current solution could be improved so that it could avoid reconfiguring if it was not using relative paths. It could also be improved to only rebuild the relevant file (NSPathUtilitires) if someone wants to contribute patches for that.

Richard Frith-Macdonald <CaS>
Project Member
Tue 06 Jan 2009 02:41:22 AM UTC, original submission:

Kind of a weird little bug. Whenever I pass "make GNUSTEP_INSTALLATION_DOMAIN=SYSTEM install" to gnustep-base 1.18.0 it will start reconfiguring after I had already run "./configure" and "make".

It is a 1.18.0 problem, I tried with -make 2.0.7 and 2.0.6. Base 1.16.3 does not do this.

Stef <stefanbidi>
Project Member

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by nico (Posted a comment)
  • -unavailable- added by CaS (Posted a comment)
  • -unavailable- added by stefanbidi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 30 Jan 2009 07:18:34 PM UTCCaSOpen/ClosedIn Test=>Closed
    Tue 06 Jan 2009 10:15:42 AM UTCnicoOpen/ClosedClosed=>In Test
    Tue 06 Jan 2009 04:30:38 AM UTCCaSStatusNone=>Invalid
      Privacy(Error - Not Found)=>Public
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1