bugLiquid War 6 - Bugs: bug #25224, Beta 5 does not compile, macro...

 
 

bug #25224: Beta 5 does not compile, macro error

Submitted by:  Tom Dickson-Hunt <alethiophile>
Submitted on:  Thu 01 Jan 2009 09:22:52 PM UTC  
 
Category: InstallSeverity: 3 - Normal
Status: FixedPrivacy: Public
Assigned to: Christian Mauduit <ufoot>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat 10 Jan 2009 09:05:06 PM UTC, comment #6:

Fix is in 0.0.6beta, which is out.

Christian Mauduit <ufoot>
Project AdministratorIn charge of this item.
Sun 04 Jan 2009 08:10:59 PM UTC, comment #5:

It's fixed in the latest version checked out via arch.

Tom Dickson-Hunt <alethiophile>
Fri 02 Jan 2009 08:02:39 AM UTC, comment #4:

OK, thanks for tracking this bug down, I'll check and fix the configure.ac script, which is obviously broken somewhere arround --enable-optimize.

0.0.6beta is planned for this month (January 2009), will hopefully close this bug.

Have a nice day,

ufoot.

Christian Mauduit <ufoot>
Project AdministratorIn charge of this item.
Fri 02 Jan 2009 05:18:14 AM UTC, comment #3:

I tried again with ./configure --disable-console --disable-optimize. It had the same problem. I commented out the #ifdef that checked if optimization was used; it worked. I assume that means a problem with configure/autotools.

Tom Dickson-Hunt <alethiophile>
Thu 01 Jan 2009 11:22:46 PM UTC, comment #2:

I didn't use --enable-optimize; the only thing I did was --disable-console.

Tom Dickson-Hunt <alethiophile>
Thu 01 Jan 2009 10:18:16 PM UTC, comment #1:

OK, concerning bug #24315, I'll try to install another distribution to fix that, but doesn't show on my Debian.

Concerning your problem with the broken "LW6SYS_CALLOC(SIZE) calloc(SIZE)" #define, it's indeed totally uncompilable, but, I'm surprised, this code should be compiled only if --enable-optimize is set. Did you pass this switch. Disabling it should use the default definitions for LW6SYS_CALLOC and LW6SYS_REALLOC, which are, hopefully, correct.

Thanks for your feedback, and happy new year,

ufoot.

PS: I fixed the broken macros for next release, anyway.

Christian Mauduit <ufoot>
Project AdministratorIn charge of this item.
Thu 01 Jan 2009 09:22:52 PM UTC, original submission:

I configured beta 5, using --disable-console to avoid bug #24315. Received this error on make:

sys-file.c: In function 'lw6sys_read_file_content':
sys-file.c:90: error: too few arguments to function 'calloc'

Editing src/lib/sys/sys.h, I changed the line
#define LW6SYS_CALLOC(SIZE) calloc(SIZE)
to
#define LW6SYS_CALLOC(SIZE) calloc((SIZE), 1)
to conform to the usage of calloc().

Remade; the original error was fixed, but a new error showed up:

sys-hexa.c:191:76: error: macro "LW6SYS_REALLOC" passed 2 arguments, but takes just 1
sys-hexa.c: In function 'resize':
sys-hexa.c:191: error: 'LW6SYS_REALLOC' undeclared (first use in this function)
sys-hexa.c:191: error: (Each undeclared identifier is reported only once
sys-hexa.c:191: error: for each function it appears in.)

Tom Dickson-Hunt <alethiophile>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by ufoot (Posted a comment)
  • -unavailable- added by alethiophile (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 15 Jan 2009 01:54:38 PM UTCufootOpen/ClosedOpen=>Closed
    Thu 15 Jan 2009 01:54:17 PM UTCufootStatusReady For Test=>Fixed
    Sat 10 Jan 2009 09:05:06 PM UTCufootStatusIn Progress=>Ready For Test
    Thu 01 Jan 2009 10:18:16 PM UTCufootStatusNone=>In Progress
      Assigned toNone=>ufoot

    Back to the top


    Powered by Savane 3.1-cleanup1