bugGNU Zile (Zile is Lossy Emacs) - Bugs: bug #25108, zile-2.3.0 segfaults on (setq...

 
 

bug #25108: zile-2.3.0 segfaults on (setq unknown-var t) in ~/.zile

Submitted by:  None
Submitted on:  Wed 17 Dec 2008 02:47:02 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Status: NoneAssigned to: None
Open/Closed: ClosedRelease: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 18 Dec 2008 11:15:52 PM UTC, comment #3:

Closing; thanks.

Reuben Thomas <rrt>
Project Administrator
Thu 18 Dec 2008 08:32:25 PM UTC, comment #2:

I applied the patch from git to zile-2.3.0 (that seemed easier than figuring out what gnulib bits I need to make autogen.sh finish) and can confirm it fixed the crash there. Also ran describe-variable for the variable that previously triggered the crash, which confirmed it actually got set this time. So feel free to close this one (I'm assuming I could do that myself if I had an account here).

Anonymous
Wed 17 Dec 2008 02:56:25 AM UTC, comment #1:

Thanks for the report. I think you're right about the problem, and I've committed a fix to git. Please can you test it? It works for me (I get the crash without the fix applied, and no crash with).

Reuben Thomas <rrt>
Project Administrator
Wed 17 Dec 2008 02:47:02 AM UTC, original submission:

Running zile-2.3.0 using a .zile for a much older version of zile segfaulted on startup. Debugging reveals a missing NULL check in set_variable, I think:

#6 0x0805af0f in set_variable (var=0x894eb48 "skip-splash-screen",
val=0x894e870 "t") at ../src/variables.c:133
133 if (ent->local && cur_bp->vars == NULL)
(gdb) info locals
ent = (struct var_entry *) 0x0
key = (struct var_entry *) 0x894ecd8
(gdb) bt
#0 0xb80b2424 in __kernel_vsyscall ()
#1 0xb7f22670 in *__GI_raise (sig=6)
at ../nptl/sysdeps/unix/sysv/linux/raise.c:64
#2 0xb7f23eb8 in *__GI_abort () at abort.c:88
#3 0x080514a6 in zile_exit (doabort=1) at ../src/file.c:1294
#4 0x08057ada in segv_sig_handler (signo=11) at ../src/main.c:191
#5 <signal handler called>
#6 0x0805af0f in set_variable (var=0x894eb48 "skip-splash-screen",
val=0x894e870 "t") at ../src/variables.c:133
#7 0x0804a6b6 in F_setq (uniarg=0, arglist=0x894eaf8) at ../src/eval.c:176
#8 0x0804a585 in evaluateBranch (trybranch=0x894eaf8) at ../src/eval.c:127
#9 0x0804a6ec in leEval (list=0x894eb60) at ../src/eval.c:190
#10 0x0804aff5 in lisp_load (file=0x894e8c8 "/home/marienz/.zile")
at ../src/lisp.c:211
#11 0x08057dfd in main (argc=0, argv=0xbf8b3048) at ../src/main.c:320

Getting rid of nonexistant variables in my ~/.zile made the segfault going away, but this is obviously not the best way of telling people they need to do some housekeeping there :P

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rrt (Posted a comment)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 18 Dec 2008 11:15:52 PM UTCrrtOpen/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1