bugGNU Wget - Bugs: bug #25015, FTP downloading does not retry if...

 
 

bug #25015: FTP downloading does not retry if accept_connection() failed

Submitted by:  None
Submitted on:  Thu 04 Dec 2008 09:46:02 PM UTC  
 
Category: Program LogicSeverity: 4 - Important
Priority: 8Status: Fixed
Privacy: PublicAssigned to: None
Originator Name: Vyacheslav ChernousovOriginator Email: -unavailable-
Open/Closed: ClosedRelease: 1.11.3
Operating System: GNU/LinuxReproducibility: Every Time
Fixed Release: 1.12Planned Release: 1.12
Regression: NoneWork Required: None
Patch Included: Yes

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 16 Jun 2009 06:48:28 AM UTC, comment #2:

Fixed in 61e811876926

Micah Cowan <micahcowan>
Mon 15 Dec 2008 11:39:37 PM UTC, comment #1:

Someone else also encountered this on IRC, and was tracked down to this.

Suggested fix actually seems like the most acceptable one, to me. This is ~ line 911 of ftp.c, in the 1.11.4 sources. It certainly should not have been just returning ret/err without setting it explicitly to something.

Micah Cowan <micahcowan>
Thu 04 Dec 2008 09:46:02 PM UTC, original submission:

If using non-passive mode for FTP downloading, and connection times out while accepting connection, FTP downloading does not retry, wget just aborts with message "accept: Connection timed out."

My quick fix (however, not best) was to replace "return ret;" to "return CONERROR;".

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by micahcowan (Updated the item)
  • -unavailable- added by None (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 13 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 16 Jun 2009 06:48:28 AM UTCmicahcowanStatusConfirmed=>Fixed
      Open/ClosedOpen=>Closed
      Fixed ReleaseNone=>1.12
    Mon 15 Dec 2008 11:39:37 PM UTCmicahcowanSeverity2 - Minor=>4 - Important
      Priority6=>8
      StatusNeeds Investigation=>Confirmed
      Planned Release1.14=>1.12
    Sat 06 Dec 2008 11:26:42 PM UTCmicahcowanCategoryCrash/Freeze/Infloop=>Program Logic
      Severity3 - Normal=>2 - Minor
      Priority5 - Normal=>6
      StatusNone=>Needs Investigation
      Planned ReleaseNone=>1.14
      Patch IncludedNone=>Yes

    Back to the top


    Powered by Savane 3.1-cleanup1