bugGNUstep - Bugs: bug #24923, Built in icns drop in replacement...


bug #24923: Built in icns drop in replacement not working properly on some operating systems.

Submitted by:  Gregory John Casamento <gcasa>
Submitted on:  Mon 24 Nov 2008 10:20:05 PM UTC  
Category:  Gui/AppKit Severity:  3 - Normal
Item Group:  Bug Status:  Wont Fix
Privacy:  Public Assigned to:  Fred Kiefer <FredKiefer>
Open/Closed:  Closed

Add a New Comment (Rich Markup)

You are not logged in

Please log in, so followups can be emailed to you.


( Jump to the original submission)

Sun 01 Nov 2020 11:36:17 AM UTC, comment #8: 

I don't think this is an issue anymore.  If it pops up again we will open a bug on github.

Gregory John Casamento <gcasa>
Project Administrator
Wed 26 Aug 2009 09:53:21 PM UTC, comment #7: 

on OpenBSD/sparc32 it continues to fail

#0  0x103ed514 in icns_import_family_data (size=17258, bytes=0xeaca000 "icns",
    iconFamily=0xf7ff82bc) at NSBitmapImageRep+ICNS.m:277
#1  0x103edb2c in -[NSBitmapImageRep(ICNS) _initBitmapFromICNS:] (
    self=0xe1b7b08, _cmd=0xe1b7b08, imageData=0xb84eba8)
    at NSBitmapImageRep+ICNS.m:497
#2  0x103e559c in +[NSBitmapImageRep imageRepsWithData:] (self=0x10880b64,
    _cmd=0x108a24d0, imageData=0xb84eba8) at NSBitmapImageRep.m:269
#3  0x1046afc8 in +[NSImageRep imageRepsWithContentsOfFile:] (self=0x10880b64,
    _cmd=0x108a1570, filename=0xe1b7888) at NSImageRep.m:232
#4  0x10468070 in -[NSImage(Private) _loadFromFile:] (self=<incomplete type>,
    _cmd=0x108a1178, fileName=0xe1b7888) at NSImage.m:1833
#5  0x10466758 in -[NSImage _representationsWithCachedImages:] (
    self=<incomplete type>, _cmd=0x108a11a0, flag=0 '\000') at NSImage.m:1404
#6  0x104668e4 in -[NSImage bestRepresentationForDevice:] (
    self=<incomplete type>, _cmd=0x108a0cb8, deviceDescription=0x0)
    at NSImage.m:1434
#7  0x10462be8 in -[NSImage size] (self=<incomplete type>, _cmd=0x1087cc28)
    at NSImage.m:560
#8  0x103d22c4 in -[NSApplication setApplicationIconImage:] (self=0xba21d88,
    _cmd=0x1087c348, anImage=0xdab2248) at NSApplication.m:2210
#9  0x103ce638 in -[NSApplication finishLaunching] (self=0xba21d88,
    _cmd=0x1087c7f0) at NSApplication.m:976
#10 0x103d0190 in -[NSApplication run] (self=0xba21d88, _cmd=0x10875010)

(starting FlexiSheet)

I have no 64bit testcase though. It works on windows 32bit for me.

Riccardo Mottola <rmottola>
Project Member
Fri 21 Aug 2009 09:14:01 PM UTC, comment #6: 

I just added a fix to this code that caused it to fail on 64 bit systems. Perhaps this was the original cause of this problem. But we will never know as Greg never provided the promised example file.

Fred Kiefer <FredKiefer>
Project MemberIn charge of this item.
Tue 24 Mar 2009 10:38:42 PM UTC, comment #5: 

FlexiSheet opens fine on windows and displays its icon. So I belierve it is not a windows specific bug, it is an arhcitecture specific bug.
I tested and both Solaris, NetBSD and OpenBSD are affected on sparc for example. I bet linux would be affected too.

Riccardo Mottola <rmottola>
Project Member
Tue 17 Feb 2009 07:58:13 AM UTC, comment #4: 

Still waiting for an example that shows the problem in Windows.

We have the know issue on the sparc machine, but if there is a bigger problem we need an example to fix it.

Fred Kiefer <FredKiefer>
Project MemberIn charge of this item.
Wed 17 Dec 2008 10:40:54 PM UTC, comment #3: 

You wrote that this fails on Windows, could you please provide the icon file that causes this, so I can test on Linux and Windows. I would rather expect that this problem is hardware specific and not OS.
Perhaps it is a general problem of this implementation.

I set this bug report back to normal, as you never provided the promissed additional information.

Fred Kiefer <FredKiefer>
Project MemberIn charge of this item.
Thu 27 Nov 2008 10:37:43 PM UTC, comment #2: 

on my sparc machines we determined it to be an alignment problem. The struct needs to be padded to 4 bytes IIRC.
Possibly other machines were you tried have similar issues.

Riccardo Mottola <rmottola>
Project Member
Tue 25 Nov 2008 10:43:05 PM UTC, comment #1: 

This definitly is a gui issue, as the code is located there.

There may be endianness problems, but more likely this is an alignment problem, where pointers into structures are not properly aligned.

Fred Kiefer <FredKiefer>
Project MemberIn charge of this item.
Mon 24 Nov 2008 10:20:05 PM UTC, original submission:  

The icns drop in replacement code has problems on some operating systems.  It does not work properly due to endian issues on solaris and also fails on windows.  I will post more information as I run more tests.

Part of this issue is that when it fails it allows the NSImage object to be created and this causes issues in applications since there are no valid representations to show when they need to be displayed.  GC

Gregory John Casamento <gcasa>
Project Administrator


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by rmottola (Posted a comment)
  • -email is unavailable- added by FredKiefer (Posted a comment)
  • -email is unavailable- added by gcasa (Submitted the item)

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.




    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-11-01 gcasa StatusIn Progress => Wont Fix
        Open/ClosedOpen => Closed
    2009-10-13 FredKiefer StatusReady For Test => In Progress
        Open/ClosedIn Test => Open
    2009-08-21 FredKiefer Open/ClosedOpen => In Test
    2009-08-21 FredKiefer StatusNeed Info => Ready For Test
    2009-02-17 FredKiefer StatusNone => Need Info
        Assigned toNone => FredKiefer
    2008-12-17 FredKiefer Severity4 - Important => 3 - Normal
    2008-11-25 FredKiefer CategoryNone => Gui/AppKit

    Back to the top

    Powered by Savane 3.5