bugGnash - The GNU Flash player - Bugs: bug #24718, NULL _stage causes plugin segfaults

 
 

bug #24718: NULL _stage causes plugin segfaults

Submitted by:  Dongxu Li <butdiene>
Submitted on:  Fri 31 Oct 2008 11:30:39 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Benjamin Wolsey <bwy>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 03 Nov 2008 11:55:55 AM UTC, comment #3:

Please follow up on bug #23477 for the video problem. Which video are you talking about? Which media handler? It seems I don't get the problem with ffmpeg, but as it's intermittent I can't be sure.

Benjamin Wolsey <bwy>
Project MemberIn charge of this item.
Mon 03 Nov 2008 11:37:17 AM UTC, comment #2:

yes, I start gnash in default pause mode

segfault is fixed, but root_movie creation seems to be still problematic. sometimes, I have to "Reload" the web page to get video.

If I play the same movie URL from gnash command line, the movie always plays properly.

Maybe, more assert() needed.

Dongxu Li <butdiene>
Mon 03 Nov 2008 07:37:23 AM UTC, comment #1:

I'd guess you're starting in pause mode, and that this segfault is one reason why it works badly.

Benjamin Wolsey <bwy>
Project MemberIn charge of this item.
Fri 31 Oct 2008 11:30:39 PM UTC, original submission:

Probably this should not happen at all, but a simple check fixes segfaults for me.

--- a/gui/gui.cpp 2008-10-31 18:04:00.923732124 -0500
+++ b/gui/gui.cpp 2008-10-31 18:06:07.437884063 -0500
@@ -857,8 +857,10 @@

// @todo since we registered the sound handler, shouldn't we know
// already what it is ?!
- sound::sound_handler* s = _stage->runInfo().soundHandler();
- if ( s ) s->pause();
+ if ( _stage != NULL ) {
+ sound::sound_handler* s = _stage->runInfo().soundHandler();
+ if ( s ) s->pause();
+ }

stopHook();
}

Dongxu Li <butdiene>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16768:  gui-stop.patch added by butdiene (480B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bwy (Posted a comment)
  • -unavailable- added by butdiene (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 03 Nov 2008 11:55:55 AM UTCbwyStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Mon 03 Nov 2008 08:02:30 AM UTCbwyStatusNone=>Ready For Test
    Mon 03 Nov 2008 07:37:23 AM UTCbwyAssigned toNone=>bwy
    Fri 31 Oct 2008 11:30:39 PM UTCbutdieneAttached File-=>Added gui-stop.patch, #16768

    Back to the top


    Powered by Savane 3.1-cleanup1