Sat 31 Jan 2009 01:35:01 AM UTC, comment #16:
Looks great! All button images are in the correct place. Thanks
|
Fri 30 Jan 2009 10:56:13 PM UTC, comment #15:
I'm sorry for not responding earlier, I just simply haven't had time to boot into my test install. I'll do my best to get it test this weekend and get you an answer as soon as possible.
|
Fri 30 Jan 2009 10:21:56 PM UTC, comment #14:
I added my suggested solution to the source code as nobody else seem to have tried it from here. Perhaps that way the code will get more testing.
|
Sun 11 Jan 2009 09:34:50 PM UTC, comment #13:
I played with the line:
y = floorf(aPoint.y);
at CairoGState.m:1280 and replacing it with
y = floorf(aPoint.y + 0.5);
gives better results for these icons. But I will need to figure out why this is better and what is the real instruction that belongs here. It could as well be ceilf or roundf or perhaps depend on the flipped state of the view. And what does that mean for all the other floorf calls with y coordinates?
Any help with this would be apreciated.
|
Tue 06 Jan 2009 02:43:59 AM UTC, comment #12:
Just wanted to make sure the last message was picked up correctly since I got an error and didn't see it come up on my e-mail.
|
Sun 04 Jan 2009 02:55:10 AM UTC, comment #11:
I just tested with back 0.16.0 and the suggest fix (setting _strokeadjust = 0) did not work.
|
Tue 09 Dec 2008 11:24:41 PM UTC, comment #10:
Perhaps it isn't the image that is off, but the surrounding path is? Could you please try this with stroke adjustment turned off for the cairo backend? (Changing line 495 in CairoGState.m to _strokeadjust = 0; should do)
|
Sun 30 Nov 2008 10:20:47 PM UTC, comment #9:
Yes!
|
Sun 30 Nov 2008 09:13:36 PM UTC, comment #8:
Just to make sure I am understanding this issue correctly. Is it that the cairo backend has the contents of these two buttons one pixel to low?
|
Sun 30 Nov 2008 05:20:20 PM UTC, comment #7:
Sorry it took me so long, but I was just now able to get a screenshot. I'm attaching 2 images, 1 of cairo and 1 of art.
Let me know if this is not what you're looking for.
(file #16952, file #16953)
|
Wed 12 Nov 2008 07:50:15 AM UTC, comment #6:
Reopened and moved to backend.
Could you please provide screen shots of both the look in art and cairo? That way it will be simpler to understand what you expect and what you get.
|
Wed 12 Nov 2008 12:01:00 AM UTC, comment #5:
I'm sorry to inform that my previous statement was incorrect. Turns out this is a backend specific bug, and I had incorrectly compiled my SVN copy of GNUstep.
This is only applicable to cairo, art works fine.
To clearify, the image inside the button is what is off-set (about 1 pixel down), not the whole button.
Sorry about the confusion.
|
Sat 08 Nov 2008 11:55:05 AM UTC, comment #4:
Closed, as it was reported as already fixed.
|
Fri 07 Nov 2008 04:57:43 PM UTC, comment #3:
This is fixed in SVN. Tried it last night and the images are no longer off-center.
|
Sun 02 Nov 2008 10:38:16 PM UTC, comment #2:
OK, I'll give it a try whenever I do the install from SVN.
|
Sun 02 Nov 2008 10:01:35 PM UTC, comment #1:
Would you mind to submit a patch for this? Most likely all you need to do is change the values in the method [GSStandardWindowDecorationView updateRects]. As I am never using GSX11HandlesWindowDecorations = NO I have no way of knowing which values would give a better look :-)
|
Fri 31 Oct 2008 01:28:22 AM UTC, original submission:
When GSX11HandlesWindowDecorations = NO, the miniaturize and close button images are somewhat off center.
I know this is being really picky, but I just can't get over it!
PS: Wasn't sure if -back or -gui draw the decorations, so I left the category as unknown.
|