bugmake - Bugs: bug #24655, shell_var.length isn't set causing...

 
 

bug #24655: shell_var.length isn't set causing duplicates from target_environment.

Submitted by:  Knut St. Osmundsen <bird_tori>
Submitted on:  Sun 26 Oct 2008 10:02:30 PM UTC  
 
Severity: 3 - NormalItem Group: Bug
Status: FixedPrivacy: Public
Assigned to: Paul D. Smith <psmith>Open/Closed: Closed
Component Version: 3.81Operating System: Any
Fixed Release: 3.82Triage Status: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 04 Jun 2009 05:48:49 AM UTC, comment #1:

I can't reproduce the problem (I don't get failures in the SHELL unit tests) but I agree that the change you proposed is necessary and I've made it in the source code.

Paul D. Smith <psmith>
Project AdministratorIn charge of this item.
Sun 26 Oct 2008 10:02:30 PM UTC, original submission:

target_environment() uses a temporary hash table for collecting exported variables from the sets. This table uses variable_hash_1 and variable_hash_2 which expect the struct variable::length field to be correct and will generate incorrect values for the shell_var since its length field is 0.

The result is, for instance, that the last test in tests/scripts/variables/SHELL exports the wrong SHELL variable.

The fix is very simple, just initialize shell_var.length to 5 in main.c (line 1189 in r1.227).

Knut St. Osmundsen <bird_tori>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by psmith (Posted a comment)
  • -unavailable- added by bird_tori (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 28 Jul 2010 06:16:48 AM UTCpsmithFixed Release4.0=>3.82
    Thu 04 Jun 2009 05:48:49 AM UTCpsmithStatusNone=>Fixed
      Assigned toNone=>psmith
      Open/ClosedOpen=>Closed
      Fixed ReleaseNone=>4.0

    Back to the top


    Powered by Savane 3.1-cleanup1