bugGnash - The GNU Flash player - Bugs: bug #24654, getURL with...

 
 

bug #24654: getURL with "javascript:" doesn't work.

Submitted by:  Benjamin Wolsey <bwy>
Submitted on:  Sun 26 Oct 2008 04:14:19 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 27 Oct 2008 10:49:30 AM UTC, comment #2:

This should work again now. I've made some changes to rationalize the various getURL methods, which removes code duplication and generally does things more sensibly. Please report any bugs or review the changes, as not everything can be caught by the testsuite yet.

Benjamin Wolsey <bwy>
Project Member
Sun 26 Oct 2008 07:08:24 PM UTC, comment #1:

Things passed to the host FD should not be threated with URL,
the hosting application should know how to deal with that (tested in the past with firefox...)

You only want to resolve relative urls IFF not passing the
resulting url to host FD..

Sandro Santilli <strk>
Project Member
Sun 26 Oct 2008 04:14:19 PM UTC, original submission:

We construct a URL object from the string, which recognizes it's not a proper URL and prepends the current working directory.

I'm not sure whether (1) to adapt the URL class to allow 'javascript:' pseudo-URLs, or (2) to change movie_root, either by adding an extra public method that takes a string to write to the host FD, or by having movie_root::getURL() take a string instead of a URL, in which case there's no automatic validation of URLs passed.

The first option would mean no special handling of "javascript:" is needed in ASHandlers and no change to movie_root, the second means no changes to URL class.

Benjamin Wolsey <bwy>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by bwy (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 30 Oct 2008 11:54:56 AM UTCbwyStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Mon 27 Oct 2008 10:49:30 AM UTCbwyStatusNone=>Ready For Test

    Back to the top


    Powered by Savane 3.1-cleanup1