bugGNUstep - Bugs: bug #24564, build failure on solaris

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #24564: build failure on solaris

Submitted by:  Riccardo Mottola <rmottola>
Submitted on:  Tue 14 Oct 2008 09:38:55 PM UTC  
 
Category: Base/FoundationSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Wed 15 Oct 2008 04:53:53 AM UTC, comment #1:

Thanks ...I changed that as suggested.

Richard Frith-Macdonald <CaS>
Project Member
Tue 14 Oct 2008 09:38:55 PM UTC, original submission:

on solaris 2.5, gcc 2.95, I get:

GSSocketStream.m: In function `-[GSSocketStream _setSocketAddress:port:family:]':
GSSocketStream.m:1394: warning: implicit declaration of function `inet_pton'
GSSocketStream.m: In function `-[GSSocketInputStream close]':
GSSocketStream.m:1683: `SHUT_RD' undeclared (first use in this function)
GSSocketStream.m:1683: (Each undeclared identifier is reported only once
GSSocketStream.m:1683: for each function it appears in.)
GSSocketStream.m: In function `-[GSSocketInputStream _dispatch]':
GSSocketStream.m:1900: warning: passing arg 4 of `getsockopt' from incompatible pointer type

I propose the following for the SHUT_RD missing:
#ifndef SHUT_RD
#define SHUT_RD 0
#define SHUT_WR 1
#define SHUT_RDWR 2
#endif

I have seen that in old code often the numbers were used directly and the modern manpage explicitely state that those values are hard-coded.

Or maybe a more expensive configure check should be used?

Riccardo Mottola <rmottola>
Project Member

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by CaS (Posted a comment)
  • -unavailable- added by rmottola (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 15 Oct 2008 04:53:53 AM UTCCaSStatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1