bugPSPP - Bugs: bug #24553, "make check" reports...

 
 

bug #24553: "make check" reports tests/command/insert.sh failure with /tmp symlinked

Submitted by:  Ben Pfaff <blp>
Submitted on:  Tue 14 Oct 2008 01:01:26 AM UTC  
 
Category: NoneSeverity: 5 - Average
Status: FixedAssigned to: None
Open/Closed: ClosedRelease: None
Effort: 0.00

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 08 Nov 2008 09:24:56 AM UTC, comment #3:

I pushed a fix for this.

John Darrington <jmd>
Project Administrator
Tue 04 Nov 2008 03:58:40 AM UTC, comment #2:

>Does anyone see any problems if we just drop the use of
>canonicalise_file_name ?


I can't think of a problem. Canonicalization is kind of a last resort. It tends to create problems, in my experience.

Ben Pfaff <blp>
Project Administrator
Mon 03 Nov 2008 06:00:18 AM UTC, comment #1:

The problem appears to be the use of canonicalise_file_name.

When I wrote that bit of code, I seem to remember I wanted an absolute file name, not necessarily a canonical one. I think I was worried about x.sps including another file called x.sps in a different directory, and raising an ambiguity in the file name reported by error messages.

However, thinking about it now, I don't think there's a problem, as all filenames will be referenced to the current directory.

Does anyone see any problems if we just drop the use of canonicalise_file_name ?

John Darrington <jmd>
Project Administrator
Tue 14 Oct 2008 01:01:26 AM UTC, original submission:

Richard Brittain reports the following:

> I get 1 failing test in the set of 158. The actual message is:
> 1c1
> < /private/tmp/pspp-tst-8859/foo.sps:10: error: DISPLAY: AKSDJ is not a variable name.
> ---
> > /tmp/pspp-tst-8859/foo.sps:10: error: DISPLAY: AKSDJ is not a variable name.
> 3c3
> < /private/tmp/pspp-tst-8859/foo.sps:10: error: Stopping syntax file
> processing here to avoid a cascade of dependent command failures.
> ---
> > /tmp/pspp-tst-8859/foo.sps:10: error: Stopping syntax file
> > processing
> here to avoid a cascade of dependent command failures.
> examine output 1
> FAILED
> FAIL: tests/command/insert.sh


In a followup, he notes:

> On OSX, /tmp symlinks to /private/tmp - I think it is just to make it
> easier to stop the finder from browsing down that tree too easily. I
> presume that the other tests also write files in /tmp, so that in
> itself isn't causing the problem.


We should make sure that a symlinked /tmp works properly with "make check".

Ben Pfaff <blp>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jmd (Posted a comment)
  • -unavailable- added by blp (bug reporter)
  • -unavailable- added by blp (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 08 Nov 2008 09:24:56 AM UTCjmdStatusConfirmed=>Fixed
      Open/ClosedOpen=>Closed
    Mon 03 Nov 2008 06:00:17 AM UTCjmdStatusNone=>Confirmed
    Tue 14 Oct 2008 01:01:27 AM UTCblpCarbon-Copy-=>Added richard brittain

    Back to the top


    Powered by Savane 3.1-cleanup1