bugGnash - The GNU Flash player - Bugs: bug #24429, This page makes FF3 lock up upon...

 
 

bug #24429: This page makes FF3 lock up upon loading

Submitted by:  Ed Martin <edman007>
Submitted on:  Thu 02 Oct 2008 01:43:03 AM UTC  
 
Category: NoneSeverity: 5 - Blocker
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri 03 Oct 2008 11:20:54 AM UTC, comment #6:

Just a note, when we get such parser exception is often because our parser doesn't support some verison-specific flavor of a tag.
For this case, might be worth comparing listswf and gnash -vp outputs, as we know we dont' support SWF8 and higher tags very well yet.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Fri 03 Oct 2008 11:02:29 AM UTC, comment #5:

Fixed. Whether to continue parsing the next tag after a parsing exception isn't so obvious, and I don't know what the pp does.

Because we can't find out with much certainty what the pp regards as a serious enough malformation to stop, we should probably continue trying to parse the rest of the movie. It's unlikely to be a compatibility issue, and Gnash should be robust enough to take any old rubbish.

I'd make that change straight after the release (or release branch).

Benjamin Wolsey <bwy>
Project Member
Thu 02 Oct 2008 04:16:18 PM UTC, comment #4:

Implementation of the proposal committed (revno 9905).

The further improvement I'd be scared about doing for this release (but I'll leave that decision to bwy)

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 02 Oct 2008 03:39:36 PM UTC, comment #3:

Proposal:

- we add an SWFStream::consumeInput() method to ensure IOChannel is fully consumed on premature parser interruption.
- we call that method by the end of SWFMovieDefinition::read_all_swf

For further improvement:
- we add a local try/catch for single tag loader

How does it sound ?

NOTE: this is assuming the plugin hangs on writing to gnash stdin because gnash stops reading it.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 02 Oct 2008 07:02:23 AM UTC, comment #2:

The direct link is http://fantasticcontraption.com/game/Contraption.swf

Benjamin Wolsey <bwy>
Project Member
Thu 02 Oct 2008 06:57:55 AM UTC, comment #1:

This is SWF9 and needs AVM2, so there's no chance of it working yet.

Gnash says: ERROR: Parsing exception: premature end of tag: need to read 2 bytes, but only 0 left in this tag.

More interestingly, the pp (9,0,115,0) says:

TypeError: Error #1009: Cannot access a property or method of a null object reference.
at Contraption()[C:\development\whirled\Contraption\Contraption.as:75]

I've never seen anything like that before.

I'm not sure why Gnash is locking up the browser (does for Epiphany as well).

Benjamin Wolsey <bwy>
Project Member
Thu 02 Oct 2008 01:43:03 AM UTC, original submission:

Hi,
When attempting to load http://fantasticcontraption.com/ in FF3 the browser just locks up. the gnash process spawned by FF needs to be killed to make the browser usable again.

I'm using trunk from 9/29/08 and i'm on x86_64

my config line

Renderer: cairo - GUI: GTK - Media handler: ffmpeg
Configured with: --prefix=/usr --libdir=/usr/lib64 --sysconfdir=/etc --localstatedir=/var --mandir=/usr/man --docdir=/usr/doc/gnash-bzr --enable-gui=gtk --enable-renderer=cairo --enable-jpeg --enable-freetype2 --enable-fontconfig --enable-Xft --enable-gstreamer --with-ffmpeg-incl=/usr/include --enable-media=ffmpeg
CXXFLAGS: -O3 -fPIC -march=native -pthread -pthread -W -Wall -Wcast-align -Wcast-qual -Wpointer-arith -Wreturn-type -Wnon-virtual-dtor -Wunused

Ed Martin <edman007>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Updated the item)
  • -unavailable- added by bwy (Posted a comment)
  • -unavailable- added by edman007 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 03 Oct 2008 11:02:29 AM UTCbwyStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Thu 02 Oct 2008 04:16:18 PM UTCstrkStatusIn Progress=>Ready For Test
    Thu 02 Oct 2008 03:39:36 PM UTCstrkStatusConfirmed=>In Progress
      Assigned toNone=>strk
    Thu 02 Oct 2008 03:06:08 PM UTCstrkSeverity3 - Normal=>5 - Blocker
    Thu 02 Oct 2008 06:57:55 AM UTCbwyStatusNone=>Confirmed

    Back to the top


    Powered by Savane 3.1-cleanup1