bugGnash - The GNU Flash player - Bugs: bug #24348, Text displays vertically

 
 

bug #24348: Text displays vertically

Submitted by:  Benjamin Wolsey <bwy>
Submitted on:  Mon 22 Sep 2008 07:55:06 PM UTC  
 
Category: coreSeverity: 5 - Blocker
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 24 Sep 2008 09:35:07 PM UTC, comment #10:

Committed revision 9833:
don't reset bounding box if wordWrap is true...

Sandro Santilli <strk>
Project MemberIn charge of this item.
Wed 24 Sep 2008 07:52:05 PM UTC, comment #9:

it looks like wordWrap is true.
In that case, wordWrap takes precedence over autoSize.

Simple solution might be just NOT touching the bounding
box (which is what fixed the other bug in the autoSize=none
case). At least in the wordWrap case...

Sandro Santilli <strk>
Project MemberIn charge of this item.
Wed 24 Sep 2008 06:07:44 PM UTC, comment #8:

Make check indeed fails when that line is reverted, but the movie displays correctly.

Benjamin Wolsey <bwy>
Project Member
Wed 24 Sep 2008 05:44:28 PM UTC, comment #7:

Did you try 'make check' with that line reverted ?
Anyway bug #24266 was for autoSize=none, where we
used to reset the bounding box to the one specified
at creation time.
The correct behaviour seems to NOT do that.

So the line you're talking about should not be relevant
at all as it's only entered for autoSize!=none.

Still, can't remember why the bounds need to be
reset in that case. Probably to ensure that when you
set a smaller text the boundary don't keep the dimensions
they picked up when you did set bigger text.

Why definition width would be different then no dimension
at all I've no idea as I'd think on autoSize!=none we'd
be expanding the boundign box as needed to fit the text in.

It can have to do with the direction of the expansion
(vertical or horizontal). Should also have to do with the
actual value of autoSize (center,left,top) and possibly with
alignment too.

Sorry to be adding more confusion but this is what I remember
about the whole thing.

Hopefully 'make check' will tell you more (I think/hope I did
add automated tests for bug #24266).

Sandro Santilli <strk>
Project MemberIn charge of this item.
Wed 24 Sep 2008 05:25:46 PM UTC, comment #6:

It was revision 9750 that broke it, so it is related to bug #24266. Changing line 1217 of edit_text_character.cpp back to

_bounds.set_to_rect(0, 0, defBounds.get_x_max(), 0);

fixes this case, and moreover doesn't appear to break the 000.swf test from bug #24266, so I'm not sure what fixed that bug any more.

Benjamin Wolsey <bwy>
Project Member
Wed 24 Sep 2008 03:36:22 PM UTC, comment #5:

I haven't made very much progress with narrowing this down, but the attached files put in the same directory display the vertical text bug.

Maybe relevant:

21985:47515672841312] 17:35:13 DEBUG: TextField.autoSize != 'none' TESTING

(file #16562, file #16563)

Benjamin Wolsey <bwy>
Project Member
Tue 23 Sep 2008 06:47:09 AM UTC, comment #4:

Looks very ListBoxy doesn't it ?
bug #24266 isn't closed yet, btw...

Sandro Santilli <strk>
Project MemberIn charge of this item.
Tue 23 Sep 2008 06:39:22 AM UTC, comment #3:

You have to click on a continent first so that the news item icons appear, then hover over a news item.

If you run http://atlas.tagesschau.de/index12.swf?modus=&country=deutschland directly you should see them (news icons). The "Länder-Informationen" button in the top right also opens a box with vertical text.

Benjamin Wolsey <bwy>
Project Member
Tue 23 Sep 2008 06:10:30 AM UTC, comment #2:

Which text ? I see no vertical text by running:

gtk-gnash http://atlas.tagesschau.de/index12.swf

The only text is in title (top), menu item names (top)
and bottom text.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 22 Sep 2008 07:57:32 PM UTC, comment #1:

The border is much too wide as well.

Benjamin Wolsey <bwy>
Project Member
Mon 22 Sep 2008 07:55:06 PM UTC, original submission:

The text on the SWF here:

http://atlas.tagesschau.de/index12.swf?modus=&country

has become vertical again (hover over a news item to see the problem). Unless the SWF has changed, this is a regression, and I guess it has to do with textfield width.

Benjamin Wolsey <bwy>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16562:  statDaten.swf added by bwy (146KiB - application/x-shockwave-flash)
file #16563:  readStatDatenNeu.php added by bwy (10KiB - application/x-php)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by bwy (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 25 Sep 2008 07:39:09 AM UTCbwyStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Wed 24 Sep 2008 09:35:07 PM UTCstrkCategoryNone=>core
      StatusConfirmed=>Ready For Test
      Assigned toNone=>strk
    Wed 24 Sep 2008 03:36:22 PM UTCbwyAttached File-=>Added statDaten.swf, #16562
      Attached File-=>Added readStatDatenNeu.php, #16563
    Tue 23 Sep 2008 06:47:09 AM UTCstrkStatusNone=>Confirmed

    Back to the top


    Powered by Savane 3.1-cleanup1