bugLiquid War 6 - Bugs: bug #24315, Beta4 fails to compile, readline...

 
 

bug #24315: Beta4 fails to compile, readline error

Submitted by:  None
Submitted on:  Sat 20 Sep 2008 01:43:56 AM UTC  
 
Category: InstallSeverity: 3 - Normal
Status: FixedPrivacy: Public
Assigned to: Christian Mauduit <ufoot>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat 10 Jan 2009 09:05:01 PM UTC, comment #9:

Fix is in 0.0.6beta, which is out.

Christian Mauduit <ufoot>
Project AdministratorIn charge of this item.
Sun 04 Jan 2009 08:11:24 PM UTC, comment #8:

This is fixed in the latest version checked out by arch.

Tom Dickson-Hunt <alethiophile>
Fri 02 Jan 2009 02:24:05 PM UTC, comment #7:

OK, searching on the Net I found code snippets where <stdlib.h> and <string.h> were also included along with <stdio.h> before including <readline/readline.h>. But I'm not sure this is really the problem, because -> it happens that I acted as a moroon and didn't look carefully at the "slightly different error", which is in cns-history.c and not in cns-handler.c anymore. Point is readline headers are also included in cns-history.c therefore an #include <stdio.h> must also be added in this file. Patched code looks like:

#include <stdio.h>
#include <readline/history.h>

This fix will be included in next release (0.0.6beta).

Have a nice day,

ufoot.

Christian Mauduit <ufoot>
Project AdministratorIn charge of this item.
Thu 01 Jan 2009 08:54:02 PM UTC, comment #6:

No. I'm getting the same error.

Tom Dickson-Hunt <alethiophile>
Mon 22 Dec 2008 09:27:53 AM UTC, comment #5:

Question : what happens with 0.0.5beta & console enabled? Is it fixed?

Thanks for your feedback,

Christian.

Christian Mauduit <ufoot>
Project AdministratorIn charge of this item.
Sat 20 Sep 2008 11:45:27 PM UTC, comment #4:

Well compiling without console support worked fine. But I'm happy to keep testing with console to get this issue fixed.

Kieran <k776>
Project Member
Sat 20 Sep 2008 11:25:09 PM UTC, comment #3:

Now I'm getting a slightly different error, but still not compiling... Any more missing include lines I can try?

-----------

Making all in cns
make[4]: Entering directory `/home/kieran/liquidwar6-0.0.4beta/src/lib/cns'
if /bin/sh ../../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I../../.. -Wall -DLW6_UNIX -DLW6_CONSOLE -O2 -fomit-frame-pointer -march=i686 -MT cns-history.lo -MD -MP -MF ".deps/cns-history.Tpo" -c -o cns-history.lo cns-history.c; \
then mv -f ".deps/cns-history.Tpo" ".deps/cns-history.Plo"; else rm -f ".deps/cns-history.Tpo"; exit 1; fi
gcc -DHAVE_CONFIG_H -I. -I. -I../../.. -Wall -DLW6_UNIX -DLW6_CONSOLE -O2 -fomit-frame-pointer -march=i686 -MT cns-history.lo -MD -MP -MF .deps/cns-history.Tpo -c cns-history.c -fPIC -DPIC -o .libs/cns-history.o
In file included from /usr/include/readline/history.h:36,
from cns-history.c:28:
/usr/include/readline/rltypedefs.h:65: error: expected ')' before '*' token
make[4]: *** [cns-history.lo] Error 1
make[4]: Leaving directory `/home/kieran/liquidwar6-0.0.4beta/src/lib/cns'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/home/kieran/liquidwar6-0.0.4beta/src/lib'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/kieran/liquidwar6-0.0.4beta/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/kieran/liquidwar6-0.0.4beta'
make: *** [all] Error 2

Kieran <k776>
Project Member
Sat 20 Sep 2008 12:15:14 PM UTC, comment #2:

OK, I investigated a bit. On my system the rltypedefs.h include in readline.h is on line 38, not 37. Curiously, line 36, which I suspect being the "supplementary" includes stdio.h. In short, rltypedefs needs stdio.h (to be more precise, it needs at least the FILE type to be defined) and on my system readline.h handles this automatically. I imagine on yours, stdio.h is not included by default.

So here's a new fix you can try: either patch /usr/include/readline/readline.h or in LW6 src/lib/cns/cns-handler.c replace:
#include <readline/readline.h>
by:
#include <stdio.h>
#include <readline/readline.h>
This should enable compilation with console support ;)

I already commited this in the source tree, fix will be contained in the next 0.0.5beta release.

Have a nice day,

ufoot.

Christian Mauduit <ufoot>
Project AdministratorIn charge of this item.
Sat 20 Sep 2008 09:15:52 AM UTC, comment #1:

Thanks for your feedback (and interest!) about Liquid War 6.

Mmm, I guess there's must be some include missing in my code (I should maybe include something before readline.h for instance).

- the fastest "short term solution" to your problem is to use "./configure --disable-console" which should logicially cause the faulting code not to be compiled at all. This problem should then disappear. You won't have console support but this is not really mandatory, consider it as hacker's stuff
- in the long run, I must fix this problem. Could you please send me details about your OS, its version, the version of the readline package and ideally the readline.h file itself (I have the line of the error but do not know what's in this line on your system).

Thanks and have a nice day,

ufoot.

Christian Mauduit <ufoot>
Project AdministratorIn charge of this item.
Sat 20 Sep 2008 01:43:56 AM UTC, original submission:

Been watching LiquidWars 6 for 2 years now. Tried to compile beta4 today and got the following. Any ideas?

Making all in cns
make[4]: Entering directory `/home/kieran/liquidwar6-0.0.4beta/src/lib/cns'
if /bin/sh ../../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I../../.. -Wall -DLW6_UNIX -DLW6_CONSOLE -g -O2 -MT cns-handler.lo -MD -MP -MF ".deps/cns-handler.Tpo" -c -o cns-handler.lo cns-handler.c; \
then mv -f ".deps/cns-handler.Tpo" ".deps/cns-handler.Plo"; else rm -f ".deps/cns-handler.Tpo"; exit 1; fi
gcc -DHAVE_CONFIG_H -I. -I. -I../../.. -Wall -DLW6_UNIX -DLW6_CONSOLE -g -O2 -MT cns-handler.lo -MD -MP -MF .deps/cns-handler.Tpo -c cns-handler.c -fPIC -DPIC -o .libs/cns-handler.o
In file included from /usr/include/readline/readline.h:37,
from cns-handler.c:31:
/usr/include/readline/rltypedefs.h:65: error: expected ')' before '*' token
In file included from cns-handler.c:31:
/usr/include/readline/readline.h:416: error: expected ')' before '*' token
/usr/include/readline/readline.h:532: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token
/usr/include/readline/readline.h:533: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token
/usr/include/readline/readline.h:555: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token
/usr/include/readline/readline.h:827: error: expected specifier-qualifier-list before 'FILE'
make[4]: *** [cns-handler.lo] Error 1
make[4]: Leaving directory `/home/kieran/liquidwar6-0.0.4beta/src/lib/cns'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/home/kieran/liquidwar6-0.0.4beta/src/lib'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/kieran/liquidwar6-0.0.4beta/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/kieran/liquidwar6-0.0.4beta'
make: *** [all] Error 2

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by alethiophile (Posted a comment)
  • -unavailable- added by k776 (Posted a comment)
  • -unavailable- added by ufoot (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 15 Jan 2009 01:54:28 PM UTCufootStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sat 10 Jan 2009 09:05:01 PM UTCufootStatusIn Progress=>Ready For Test
    Fri 02 Jan 2009 02:24:05 PM UTCufootStatusReady For Test=>In Progress
    Sat 20 Sep 2008 12:15:13 PM UTCufootStatusIn Progress=>Ready For Test
    Sat 20 Sep 2008 09:16:36 AM UTCufootCategoryNone=>Install
      StatusNone=>In Progress
      Assigned toNone=>ufoot

    Back to the top


    Powered by Savane 3.1-cleanup1