bugGnash - The GNU Flash player - Bugs: bug #24310, building against ffmpeg trunk fails

 
 

bug #24310: building against ffmpeg trunk fails

Submitted by:  Miklos Vajna <vmiklos>
Submitted on:  Fri 19 Sep 2008 04:46:08 PM UTC  
 
Category: buildSeverity: 5 - Blocker
Release: trunkStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 22 Sep 2008 07:50:26 PM UTC, comment #13:

Works fine for me for two versions of ffmpeg as well.

Benjamin Wolsey <bwy>
Project Member
Mon 22 Sep 2008 07:21:18 PM UTC, comment #12:

Great!

gnash-bzr9811 now builds fine for me using ffmpeg-svn15366 on i686.

Miklos Vajna <vmiklos>
Mon 22 Sep 2008 05:45:47 PM UTC, comment #11:

51.50.1 also works now. There we have to parse LIBAVCODEC_VERSION_TRIPLET instead of LIBAVCODEC_VERSION..

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 22 Sep 2008 05:16:09 PM UTC, comment #10:

I committed a workaround for the INT64_C bug, now all versions
from 51.11.0 to 52.0.0 should be supported.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 22 Sep 2008 04:40:26 PM UTC, comment #9:

Same undeclared INT64_C bug in 51.40.4

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 22 Sep 2008 03:11:51 PM UTC, comment #8:

On a side-note: 51.40.2 configures fine, but breaks on build
with this:

/usr/local/include/ffmpeg/avformat.h:66: error: 'INT64_C' was not declared in this scope

Is it a bug in ffmpeg itself ?

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 22 Sep 2008 01:49:30 PM UTC, comment #7:

Another successful detection test:

checking ffmpeg version... 51.11.0 (511100) -- Debian 4.0

configure: WARNING: This version of ffmpeg/libavcodec (51.11.0) is not able to play VP6 encoded video: 51.27.0 or higher required!
configure: WARNING: This version of ffmpeg/libavcodec (51.11.0) is not able to play VP6A encoded video: 51.49.0 or higher required!

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 22 Sep 2008 12:40:26 PM UTC, comment #6:

Build with ffmpeg trunk (52.0.0) succeeds now with gnash trunk, except I have to add -lbz2 to LDFLAGS or matroska_decode_buffer
from ffmpeg won't find the required symbols.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 22 Sep 2008 10:25:44 AM UTC, comment #5:

I've committed the patch. Next problem seems to be with custom
include paths as the new ffmpeg (major:52) installs libavcodec
and libavformat includes in different subdirs so we should
probably have LIBAVCODEC_CFLAGS and LIBAVFORMAT_CFLAGS.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 22 Sep 2008 10:02:05 AM UTC, comment #4:

Update to the previous patch. Was requiring 51.40.30 for swscale.
Thanks bwy for noticing.

(file #16540)

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 22 Sep 2008 09:49:57 AM UTC, comment #3:

The attached patch cleans up ffmpeg version detection code
and improves output messages (warnings/informational).

It's been tested with the following ffmpeg versions:

checking ffmpeg version... 51.38.0 (513800) -- Ubuntu stable
checking ffmpeg version... 51.40.2 (514002) -- svn 2007 04
checking ffmpeg version... 51.40.4 (514004) -- svn 2007 06
checking ffmpeg version... 52.0.0 (520000) -- svn 2008 09

As you can see the trick was forming an padded version num.
Should work as long as major, minor and micro versions are
all less or equal 99.

Tests with older versions are appreciated.

(file #16539)

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sun 21 Sep 2008 12:02:38 PM UTC, comment #2:

It's a blocker.

Benjamin Wolsey <bwy>
Project Member
Fri 19 Sep 2008 04:52:23 PM UTC, comment #1:

Our way to extract ffmpeg version is indeed naive.

If we can rely on LIBAVCODEC_VERSION_MAJOR and LIBAVCODEC_VERSION_MINOR it would probably be better.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Fri 19 Sep 2008 04:46:08 PM UTC, original submission:

At the moment I have ffmpeg-20080427 installed. I tried building
gnash against ffmpeg trunk, but it seems it won't work with it:

checking ffmpeg version... 5200
configure: WARNING: Wrong ffmpeg/libavcodec version! 51.11.0 or greater required

I guess it's because it thinks 52.0.0 < 51.11.0 (which is what the
numeric comparision in macros/ffmpeg.m4 does after dropping the dots).

Thanks!

Miklos Vajna <vmiklos>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16540:  ffmpeg_detection2.patch added by strk (6KiB - application/octet-stream)
file #16539:  ffmpeg_detection.patch added by strk (6KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bwy (Posted a comment)
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by vmiklos (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 23 Sep 2008 06:03:13 AM UTCstrkStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Mon 22 Sep 2008 10:02:05 AM UTCstrkAttached File-=>Added ffmpeg_detection2.patch, #16540
    Mon 22 Sep 2008 09:49:57 AM UTCstrkAttached File-=>Added ffmpeg_detection.patch, #16539
      StatusConfirmed=>Ready For Test
      Assigned tonelsonrn=>strk
    Sun 21 Sep 2008 12:02:38 PM UTCbwySeverity3 - Normal=>5 - Blocker
    Fri 19 Sep 2008 04:52:23 PM UTCstrkStatusNone=>Confirmed
      Assigned toNone=>nelsonrn

    Back to the top


    Powered by Savane 3.1-cleanup1