bugGnash - The GNU Flash player - Bugs: bug #24187, Testsuite failures since...

 
 

bug #24187: Testsuite failures since -fshort-wchar introduction

Submitted by:  Benjamin Wolsey <bwy>
Submitted on:  Tue 02 Sep 2008 06:56:52 AM UTC  
 
Category: buildSeverity: 5 - Blocker
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Russ Nelson <nelsonrn>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 03 Sep 2008 06:47:15 PM UTC, comment #6:

Me too.

Benjamin Wolsey <bwy>
Project Member
Wed 03 Sep 2008 12:45:10 PM UTC, comment #5:

Fixed for me now

Sandro Santilli <strk>
Project Member
Tue 02 Sep 2008 02:42:27 PM UTC, comment #4:

I can reproduce the problem.
actionscript.all/String.as has many occurrences.

Sandro Santilli <strk>
Project Member
Tue 02 Sep 2008 08:05:04 AM UTC, comment #3:

At least some of the failures are because my stdlibc++ can't cope with two-byte wchar_t. When we use std::wstring functions (e.g find()) after compiling with -fshort-wchar, the stdlib causes memory errors and fails.

Not sure whether it's a bug in the stdlib implementation, or whether you can't expect it to cope with a shorter wchar_t than it wants, but I doubt I'm the only one to have this problem.

Benjamin Wolsey <bwy>
Project Member
Tue 02 Sep 2008 07:29:54 AM UTC, comment #2:

No, doesn't help. There are now 298 unexpected failures in the testsuite.

I'm going to look at it as we ought to allow building with a short wchar, but I'm not really happy with imposing a restriction like that (not all utf-8 characters can be expressed in two bytes) just because XPCOM is a pile of shit.

Benjamin Wolsey <bwy>
Project Member
Tue 02 Sep 2008 07:01:44 AM UTC, comment #1:

Wait a sec - there was another commit besides that, and I'm sure that's the reason.

-fshort-wchar.

Perhaps a complete rebuild will help that.

Benjamin Wolsey <bwy>
Project Member
Tue 02 Sep 2008 06:56:52 AM UTC, original submission:

I have lots of failures in the testsuite since the introduction of the single stack:

swfdec: charat and fromcharcode (versions 6, 7, 8).
actionscript-all: String.as (fromCharcode corrupts memory there besides other failures) and ASNative.as (various failures).

Was something missing from the commit?

Benjamin Wolsey <bwy>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Updated the item)
  • -unavailable- added by bwy (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 03 Sep 2008 06:47:15 PM UTCbwyStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Wed 03 Sep 2008 12:45:09 PM UTCstrkStatusConfirmed=>Ready For Test
    Tue 02 Sep 2008 02:42:27 PM UTCstrkStatusNone=>Confirmed
    Tue 02 Sep 2008 10:31:21 AM UTCstrkCategoryNone=>build
      Assigned toNone=>nelsonrn
      SummaryTestsuite failures=>Testsuite failures since -fshort-wchar introduction
    Tue 02 Sep 2008 07:01:44 AM UTCbwyAssigned tostrk=>None

    Back to the top


    Powered by Savane 3.1-cleanup1