bugGNUstep - Bugs: bug #24153, NSCell.h declares inline without...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #24153: NSCell.h declares inline without implementation

Submitted by:  Truls Becken <bogomipz>
Submitted on:  Thu 28 Aug 2008 07:06:10 AM UTC  
 
Category: Gui/AppKitSeverity: 3 - Normal
Item Group: BugStatus: Fixed
Privacy: PublicAssigned to: Fred Kiefer <FredKiefer>
Open/Closed: Closed

Mon 08 Sep 2008 07:07:37 PM UTC, comment #2:

I just submitted a bigger patch that should resolve this issue. The inline function is now in GSTheme.h, contains new code and declared as static.
I added four additional methods to GSTheme to do border size computation and border drawing. This should allow themes to be freer in the way borders get drawn.

Fred Kiefer <FredKiefer>
Project MemberIn charge of this item.
Sat 06 Sep 2008 10:11:26 PM UTC, comment #1:

There are different ways to resolve this issue. The simplest would be to make this function non-inlined, the next to put the code in the header. But I don't like either of them. I would prefer to remove this function completely, at least from our public header files and replace it with a method on GSTheme (with a corresponding, drawBorder: method there as well).

For this we should be more or less sure that there are no applications out there that rely on this internal function. Does anybody know of one? For a while we could keep a function with the same name, but different implementation in the GSTheme header, if this helps.

Fred Kiefer <FredKiefer>
Project MemberIn charge of this item.
Thu 28 Aug 2008 07:06:10 AM UTC, original submission:

<AppKit/NSCell.h> declares function _sizeForBorderType inline, but does not provide an implementation.

This prevents EtoileXML.framework in EtoileFoundation from compiling, as shown in the attached build log. Both GNUstep and Étoilé were checked out of Subversion on 2008-08-27.

I am not an Étoilé developer and do not know if they really need this to be fixed, but it is a bug in AppKit nevertheless.

Truls Becken <bogomipz>

 

Attached Files
file #16374:  etoile_xml.txt added by bogomipz (2KiB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by FredKiefer (Posted a comment)
  • -unavailable- added by bogomipz (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 29 Nov 2008 01:53:11 PM UTCFredKieferStatusReady For Test=>Fixed
      Open/ClosedIn Test=>Closed
    Mon 08 Sep 2008 07:07:37 PM UTCFredKieferStatusNone=>Ready For Test
      Assigned toNone=>FredKiefer
      Open/ClosedOpen=>In Test
    Thu 28 Aug 2008 07:06:10 AM UTCbogomipzAttached File-=>Added etoile_xml.txt, #16374

    Back to the top


    Powered by Savane 3.1-cleanup1