bugGNU Screen - Bugs: bug #24112, NULL pointer dereference in help...

 
 

bug #24112: NULL pointer dereference in help screen when you have a nested window

Submitted by:  None
Submitted on:  Thu 21 Aug 2008 01:24:50 AM UTC  
 
Category: Crash/Freeze/InfloopSeverity: 4 - Important
Priority: 7 - HighStatus: Invalid
Privacy: PublicAssigned to: Sadrul Habib Chowdhury <sadrul>
Open/Closed: ClosedRelease: Cur Dev Sources
Fixed Release: NonePlanned Release: 4.1.0
Work Required: 0 - Hours

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 28 Mar 2010 01:41:37 AM UTC, comment #3:

The window list (and display list) has been effectively re-written. So this is not valid anymore.

Of course, if you find a crash in the current windowlist, please file a new issue. Thanks!

Sadrul Habib Chowdhury <sadrul>
Project AdministratorIn charge of this item.
Tue 26 Aug 2008 12:38:03 PM UTC, comment #2:

Sorry, I posted an incomplete bug report last time. The code in question is in WListLine(), where it's iterating through group parents to obtain indentation level:

for (group = wtab[i]->w_group, xoff = 0;
group != wlistdata->group;
group = group->w_group, xoff += 2)

As it's using wlistdata->group as sentinel, it must be set to either NULL, or one of the group parents, or the iteration reaches the root, where group->w_group == NULL.
Too bad, I lost the core file, but I'll try to reproduce it anyway; it only took me several keystrokes before catching SIGSEGV, it shouldn't be too difficult.

YONETANI Tomokazu <y0netan1>
Thu 21 Aug 2008 02:30:40 PM UTC, comment #1:

Thanks!

Is there a way to reproduce the crash?

Sadrul Habib Chowdhury <sadrul>
Project AdministratorIn charge of this item.
Thu 21 Aug 2008 01:24:50 AM UTC, original submission:

Attached is a patch I'm using as a bandaid.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16325:  help.c.diff added by None (488B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by y0netan1 (Posted a comment)
  • -unavailable- added by sadrul (Posted a comment)
  • -unavailable- added by micahcowan (Updated the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 28 Mar 2010 01:41:37 AM UTCsadrulStatusNeed Investigation=>Invalid
      Open/ClosedOpen=>Closed
    Thu 21 Aug 2008 02:30:40 PM UTCsadrulAssigned toNone=>sadrul
    Thu 21 Aug 2008 07:03:42 AM UTCmicahcowanSeverity3 - Normal=>4 - Important
      Priority5 - Normal=>7 - High
      StatusNone=>Need Investigation
      Planned ReleaseNone=>4.1.0
      Work RequiredNone=>0 - Hours
    Thu 21 Aug 2008 01:24:50 AM UTCNoneAttached File-=>Added help.c.diff, #16325

    Back to the top


    Powered by Savane 3.1-cleanup1