bugGNU Screen - Bugs: bug #24019, Code cleanup related to East Asian...

 
 

bug #24019: Code cleanup related to East Asian Ambiguous Chars patch (some)

Submitted by:  Micah Cowan <micahcowan>
Submitted on:  Fri 08 Aug 2008 01:00:08 AM UTC  
 
Category: Code ArchitectureSeverity: 2 - Minor
Priority: 2Status: Fixed
Privacy: PublicAssigned to: None
Open/Closed: ClosedRelease: None
Fixed Release: 4.1.0Planned Release: 4.1.0
Work Required: 0 - Hours

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 09 Aug 2008 06:48:04 PM UTC, comment #2:

e16843a takes care of the redundant LC_ALL, etc, code, though it could still end up being called twice. Good enough for me, though.

Micah Cowan <micahcowan>
Fri 08 Aug 2008 03:49:22 AM UTC, comment #1:

combining-chars and bisect addressed for 4.1.0 in ad3f082.

Micah Cowan <micahcowan>
Fri 08 Aug 2008 01:00:08 AM UTC, original submission:

bisearch function introduced, but code not used in a pre-existing spot in encoding.c. utf8_comb's table needs an update.

Also, should consider reworking th LC_ALL...LC_CTYPE...LANG checks in screen.c, where there's a bit of duplication.

Suggested by exg:

Micah Cowan <micahcowan>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by micahcowan (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 09 Aug 2008 06:48:04 PM UTCmicahcowanStatusConfirmed=>Fixed
      Open/ClosedOpen=>Closed
      Fixed ReleaseNone=>4.1.0
    Fri 08 Aug 2008 03:49:22 AM UTCmicahcowanPriority3 - Low=>2
    Fri 08 Aug 2008 01:07:50 AM UTCmicahcowanPriority5 - Normal=>3 - Low

    Back to the top


    Powered by Savane 3.1-cleanup1