bugGNU Screen - Bugs: bug #23945, status message can cause corrupt...

 
 

bug #23945: status message can cause corrupt caption.

Submitted by:  Micah Cowan <micahcowan>
Submitted on:  Mon 28 Jul 2008 02:51:58 AM UTC  
 
Category: User InterfaceSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: ClosedRelease: Cur Dev Sources
Fixed Release: 4.1.0Planned Release: 4.1.0
Work Required: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 29 Jul 2008 12:32:00 AM UTC, comment #3:

I applied the first patch in cb9d14bd8a198447d20ccd4be848df679a3047d9.

Sadrul Habib Chowdhury <sadrul>
Project Administrator
Mon 28 Jul 2008 09:47:25 PM UTC, comment #2:

An alternate patch: http://pidgin.im/~sadrul/pp/bug_23945_alt.patch

Sadrul Habib Chowdhury <sadrul>
Project Administrator
Mon 28 Jul 2008 07:54:11 PM UTC, comment #1:

The attached patch fixes the problem for me.

The second block of the patch is fairly self-explanatory: if we cannot refresh the requested line right now, make sure we refresh enough of the line during the next refresh request.

The first block, on the other hand, is a bit difficult to explain, especially because the need/use of display:d_status_obuf* is not clear (thanks to no relevant commit log or explanation within the source). However, I don't think there's anything that will break because of this patch.

(file #16202)

Sadrul Habib Chowdhury <sadrul>
Project Administrator
Mon 28 Jul 2008 02:51:58 AM UTC, original submission:

For me, the following steps can reproduce:

.screenrc has:
caption always "%{= bw}%-Lw%{= BW}%50>%n*%f %t%{-}%+Lw%<"

1. in one terminal, start screen, "screen -S foo".
2. in another visible terminal, start screen, "screen -xS foo".
3. Rename window 0 to "bash-bash".
4. Create a new window, and move second terminal to viewing it,
leaving first terminal viewing window 0.
5. trigger a BEL in window 0 ("printf '\a'").

The status message covers just enough space for the message itself; when it is removed, only just enough of the caption to cover the message's size is redrawn; however, the BEL has caused an additional flag for the window 0 display, so a character ends up being removed from the window 1 bit (the title shows as "bsh" or "ash").

The hardstatus (with alwayslastline) does not exhibit this problem; the message takes the entire bar, and the entire bar is redrawn. Perhaps this is appropriate for caption as well.

Micah Cowan <micahcowan>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16202:  bug_23945.patch added by sadrul (882B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by sadrul (Updated the item)
  • -unavailable- added by micahcowan (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 29 Jul 2008 12:32:00 AM UTCsadrulOpen/ClosedOpen=>Closed
      Fixed ReleaseNone=>4.1.0
    Tue 29 Jul 2008 12:31:59 AM UTCsadrulStatusConfirmed=>Fixed
    Mon 28 Jul 2008 07:54:11 PM UTCsadrulAttached File-=>Added bug_23945.patch, #16202

    Back to the top


    Powered by Savane 3.1-cleanup1