bugGNU Screen - Bugs: bug #23856, Group listing and navigation issues

 
 

bug #23856: Group listing and navigation issues

Submitted by:  Micah Cowan <micahcowan>
Submitted on:  Tue 15 Jul 2008 06:13:26 PM UTC  
 
Category: User InterfaceSeverity: 3 - Normal
Priority: 4Status: Fixed
Privacy: PublicAssigned to: Sadrul Habib Chowdhury <sadrul>
Open/Closed: ClosedRelease: None
Fixed Release: 4.1.0Planned Release: 4.1.0
Work Required: 0 - Hours

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue 12 Aug 2008 07:12:37 PM UTC, comment #11:

Sadrul, you rock.

Micah Cowan <micahcowan>
Tue 12 Aug 2008 03:20:35 PM UTC, comment #10:

I committed a change last night (ae69eb8b9604794f5fcc35920246d2c96bd7eb09) to make a new group window belong to the current group, which is the same behaviour for non-group windows too.

We can have 'f' for full display, which will basically jump to the top-most listing, and turn nested on, thus showing all the windows in the session. Sounds good?

Sadrul Habib Chowdhury <sadrul>
Project AdministratorIn charge of this item.
Sun 10 Aug 2008 01:53:19 AM UTC, comment #9:

Sadrul, that is awesomeness. I was going to suggest just such a change.

It might also be nice to have a key that jumps to the top-most listing, and/or an option that displays the full listing.

Micah Cowan <micahcowan>
Sat 09 Aug 2008 11:34:24 PM UTC, comment #8:

1f533041bed293ffa1765f89aad4197e865f463f should improve the behaviour of navigating from a parent window to a child group window.

I also added 'g' and 'm' bindings to toggle the nested/mru-ness of the windowlist.

Sadrul Habib Chowdhury <sadrul>
Project AdministratorIn charge of this item.
Sat 09 Aug 2008 04:50:20 PM UTC, comment #7:

Alright; but then descending downwards should retain the "-g" status.

Here's what I get with the following actions:

1. "windowlist -g" within a group: shows the group listing for the current group, with hierarchy if applicable.
2. C-h: shows the group listing for everything (if it was a top-level group), with hierarchy.
3. <Ret>: shows the group listing, no hierarchy.
4. C-h: shows the full listing, no hierarchy.
5. <Ret>: does nothing, emits message "this IS window X (group)."

Retitling.

Micah Cowan <micahcowan>
Sat 09 Aug 2008 12:59:28 PM UTC, comment #6:

The clearing display issue should be fixed by 3335a9c2a09e5fe3230d7d7a4030f63c4b3f6dad.

I had actually thought about making -g always show all the windows. But since nested groups are supported, I thought perhaps that wouldn't be such a good idea. This, in fact, was the motivation for the backspace binding to jump to the parent group.

Sadrul Habib Chowdhury <sadrul>
Project AdministratorIn charge of this item.
Sat 09 Aug 2008 03:53:30 AM UTC, comment #5:

Great work, Sadrul!

A couple notes: hitting "return" in an empty group window still clears the display.

"windowlist -g" only does something interesting if you're not in a group window; otherwise, you gotta hit backspace. I'm thinking "windowlist -g" should provide the full groups view.

I've another thought, but I think I'll hit the mailing list with that.

Micah Cowan <micahcowan>
Sat 09 Aug 2008 12:53:11 AM UTC, comment #4:

Pressing escape in the group window no longer empties the display (fe745b1abd186864eb1d67e17ffe6f8cb81e0da3).

This issue can probably be closed now.

Sadrul Habib Chowdhury <sadrul>
Project AdministratorIn charge of this item.
Fri 08 Aug 2008 11:16:05 PM UTC, comment #3:

The patch is applied in dfc7d7413a1557bdfcff1d4de21d93226086d0bd.

The title in the window-list shows the name of the group only when it is displaying the windows of some group. If it's displaying the toplevel windows (ie. windows that don't belong to any group), the 'Group: ' line in the title is not displayed.

Are there other suggestions/issues with group windowlists? One thing I notice is that pressing escape/^G in a group-windowlist clears the view, which I think is a bug. I'll see what I can do about that.

Sadrul Habib Chowdhury <sadrul>
Project AdministratorIn charge of this item.
Sat 19 Jul 2008 04:07:10 AM UTC, comment #2:

The attached patch adds a '-g' flag to 'windowlist' command. With this flag, the window-list appears nested according to the grouping order. The '-g' flag is also usable with the '-m' flag.

Also, from a group-window, it's possible to press ctrl+h to jump to its parent group window. I think this allows to move between windows across different groups more easily.

(file #16155)

Sadrul Habib Chowdhury <sadrul>
Project AdministratorIn charge of this item.
Tue 15 Jul 2008 09:59:28 PM UTC, comment #1:

'windowlist -m' generates the list of windows in 'most recently used' order.

To generate a 'grouped' list, perhaps there could be a '-g' param for windowlist.

Sadrul Habib Chowdhury <sadrul>
Project AdministratorIn charge of this item.
Tue 15 Jul 2008 06:13:26 PM UTC, original submission:

Running "windowlist -m" produces strange orderings. The group divisions could be made much more clear (if that's what was desired), and the listing should not be dependent on what the current group was when the list was requested. Within a group, ordering should probably be numeric; and the listing window shouldn't say "Group: group-name", since it's not actually of a group.

Micah Cowan <micahcowan>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by sadrul (Posted a comment)
  • -unavailable- added by micahcowan (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 12 Aug 2008 07:12:37 PM UTCmicahcowanStatusConfirmed=>Fixed
      Open/ClosedOpen=>Closed
      Fixed ReleaseNone=>4.1.0
    Tue 12 Aug 2008 03:20:35 PM UTCsadrulAssigned toNone=>sadrul
    Sat 09 Aug 2008 04:50:20 PM UTCmicahcowanSummaryWindowlist: funky ordering when using groups=>Group listing and navigation issues
    Sat 19 Jul 2008 04:07:10 AM UTCsadrulAttached File-=>Added windowlist_improvements.patch, #16155
    Tue 15 Jul 2008 06:14:46 PM UTCmicahcowanPriority5 - Normal=>4

    Back to the top


    Powered by Savane 3.1-cleanup1