bugGNU Screen - Bugs: bug #23817, Toggling Monitor Mode broken when...

 
 

bug #23817: Toggling Monitor Mode broken when "defmonitor" is "on".

Submitted by:  Maarten Billemont <lhunath>
Submitted on:  Fri 11 Jul 2008 11:52:30 AM UTC  
 
Category: User InterfaceSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Privacy: PublicAssigned to: Sadrul Habib Chowdhury <sadrul>
Open/Closed: ClosedRelease: 4.0.3
Fixed Release: 4.1.0Planned Release: 4.1.0
Work Required: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 12 Jul 2008 03:57:11 PM UTC, comment #3:

Fixed in 32b5a13fe0664f087bb3c279a7e49dba220dced3.

Sadrul Habib Chowdhury <sadrul>
Project AdministratorIn charge of this item.
Fri 11 Jul 2008 11:41:58 PM UTC, comment #2:

Gedge (Geraint Edwards) on IRC confirmed the fix for a multi-user session. However, he noticed that the monitoring information for the :info command was incorrect. I have attached an updated patch (and removed the old one) that fixes both the issues. The attached patch also fixes an issue where the '@' flag is displayed on an active window a different user is monitoring.

I looked at the other places where win->w_monitor is used, to see whether a similar fix was necessary. From what I could see, that doesn't seem to be the case.

(file #16106)

Sadrul Habib Chowdhury <sadrul>
Project AdministratorIn charge of this item.
Fri 11 Jul 2008 01:20:15 PM UTC, comment #1:

I can confirm the bug. The attached patch fixes it for me. But I haven't had a chance to test it in a multiuser session. (I couldn't even get a multiuser session going ...).

The patch ensures that the window-monitoring bit for the current user is set (which is what 'n' tracks for that command)

If no one else does the testing in a multiuser session, I hope to do it this weekend.

(file #16102)

Sadrul Habib Chowdhury <sadrul>
Project AdministratorIn charge of this item.
Fri 11 Jul 2008 11:52:30 AM UTC, original submission:

When using a screenrc that turns on defmonitor I can no longer toggle monitor mode with the "monitor" command or screen -X monitor.

Monitor mode is turned off on the first issuing of the command, but not turned on again when reissued.

Maarten Billemont <lhunath>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by micahcowan (Updated the item)
  • -unavailable- added by sadrul (Updated the item)
  • -unavailable- added by lhunath (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 12 Jul 2008 03:57:11 PM UTCsadrulStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
      Fixed ReleaseNone=>4.1.0
    Fri 11 Jul 2008 11:41:58 PM UTCsadrulAttached File-=>Added screen_monitor_multiuser.patch, #16106
    Fri 11 Jul 2008 11:28:17 PM UTCsadrulAttached File#16102=>Removed
    Fri 11 Jul 2008 07:56:48 PM UTCmicahcowanStatusNone=>In Progress
      Assigned toNone=>sadrul
      Planned ReleaseNone=>4.1.0
    Fri 11 Jul 2008 01:20:15 PM UTCsadrulAttached File-=>Added screen_monitor_multiuser.patch, #16102

    Back to the top


    Powered by Savane 3.1-cleanup1