bugGnash - The GNU Flash player - Bugs: bug #23790, Build error if system provides...

 
 

bug #23790: Build error if system provides isnan() macro

Submitted by:  David Brownlee <abs0>
Submitted on:  Mon 07 Jul 2008 08:44:52 AM UTC  
 
Category: release 0.8.3Severity: 3 - Normal
Release: trunkStatus: Fixed
Privacy: PublicAssigned to: Bastiaan Jacques <bjacques>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 19 Aug 2008 09:46:11 AM UTC, comment #5:

I believe rsavoye has tested this.

Benjamin Wolsey <bwy>
Project Member
Sat 16 Aug 2008 12:59:47 PM UTC, comment #4:

isnan is now renamed to isNaN: since it's a lovely function using boost for safety, not a standard function or system macro, there seems no point in insisting on the name (although conflicts like that shouldn't happen). Please test.

Benjamin Wolsey <bwy>
Project Member
Thu 10 Jul 2008 08:48:37 PM UTC, comment #3:

NetBSD 4.0 was released last december.
gnash 0.8.2 built fine on NetBSD 4.0

David Brownlee <abs0>
Mon 07 Jul 2008 05:03:36 PM UTC, comment #2:

But perhaps my suggestion defeats half of the purpose of our own isnan implementation. Hm...

Bastiaan Jacques <bjacques>
Project MemberIn charge of this item.
Mon 07 Jul 2008 05:02:40 PM UTC, comment #1:

I don't like undefing things, personally...

How about something like:

#ifndef isnan
#define isnan our_isnan_impl
template <typename T> inline bool isnan ...
#endif

?

I think NetBSD is one of the platforms tested before our last release, is 4.0 a "really new" one? :)

Bastiaan Jacques <bjacques>
Project MemberIn charge of this item.
Mon 07 Jul 2008 08:44:52 AM UTC, original submission:

If the system provides an isnan() macro then server/as_value.h fails to compile. If the system provides an isinf() macro then the compiler generates a warning.

Suggested patch attached - fixes build on NetBSD 4.0

David Brownlee <abs0>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16013:  patch-ac added by abs0 (740B - application/octet-stream - patch to fix isnan() build error)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bwy (Posted a comment)
  • -unavailable- added by bjacques (Posted a comment)
  • -unavailable- added by abs0 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 19 Aug 2008 09:46:11 AM UTCbwyStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sat 16 Aug 2008 12:59:47 PM UTCbwyReleaseNone=>trunk
      StatusNone=>Ready For Test
    Mon 07 Jul 2008 05:02:40 PM UTCbjacquesAssigned toNone=>bjacques
    Mon 07 Jul 2008 08:44:52 AM UTCabs0Attached File-=>Added patch-ac, #16013

    Back to the top


    Powered by Savane 3.1-cleanup1