bugGnash - The GNU Flash player - Bugs: bug #23491, rc2 build fails with error:...

 
 

bug #23491: rc2 build fails with error: `isfinite' undeclared

Submitted by:  Deanna Phillips <deanna>
Submitted on:  Thu 05 Jun 2008 02:35:03 AM UTC  
 
Category: buildSeverity: 4 - Important
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Benjamin Wolsey <bwy>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 05 Jun 2008 03:56:16 PM UTC, comment #7:

I guess you mean for me to be working with gnash_0_8_3_branch rather than gnash_0_8_3_rc2. It is fixed there. Thanks!

Deanna Phillips <deanna>
Thu 05 Jun 2008 03:41:20 PM UTC, comment #6:

I meant 'is it defined to 1 in gnashconfig.h?' rather than 'where is it defined?', but it seem that it is.

The problem appears to be that gnashconfig.h isn't included in utility.h, when it undoubtedly should be.

Can you update and test again?

Benjamin Wolsey <bwy>
Project MemberIn charge of this item.
Thu 05 Jun 2008 03:29:20 PM UTC, comment #5:

HAVE_FINITE is defined in gnashconfig

I have checked that this case does apply

#if defined(HAVE_FINITE) && !defined(isfinite)
# boom
# define isfinite finite
#endif

In file included from smart_ptr.h:28,
from ../server/as_object.h:26,
from sharedlib.h:33,
from extension.cpp:42:
utility.h:90:3: invalid preprocessing directive #boom

Deanna Phillips <deanna>
Thu 05 Jun 2008 03:00:59 PM UTC, comment #4:

#if defined(HAVE_FINITE) && !defined(isfinite)
# define isfinite finite
#endif

Which one of those conditions fails on OpenBSD? Is HAVE_FINITE defined in gnashconfig.h? Or is 'isfinite' defined to something?

Benjamin Wolsey <bwy>
Project MemberIn charge of this item.
Thu 05 Jun 2008 02:43:06 PM UTC, comment #3:

finite() should work

http://www.gnu.org/software/gnulib/manual/html_node/isfinite.html suggests that you should worry about this missing for at least MacOS X 10.3, OpenBSD 3.8, AIX 5.1, IRIX 6.5, OSF/1 5.1, Solaris 10, Interix 3.5.

OpenBSD's finite(3):

finite() returns the value 1 just when -Infinity < x < +Infinity; otherwise a zero is returned (when |x| = Infinity or x is NaN. The finitef() function is a single precision version of finite().

Deanna Phillips <deanna>
Thu 05 Jun 2008 07:01:00 AM UTC, comment #2:

Well, not really for me. I fixed it properly in head (or at least it should be simple to fix there if it's broken) precisely because 0.8.3 was still stuck in the land of terrible hacks.

This was caused by Dossy's fix to get it building on mingw. What is the infinite function on OpenBSD? std::isfinite or finite? I'd guess the latter.

Defining anything in namespace std:: is pretty bad, by the way, but probably not the problem here.

Benjamin Wolsey <bwy>
Project MemberIn charge of this item.
Thu 05 Jun 2008 06:00:20 AM UTC, comment #1:

seems for you, Ben

Sandro Santilli <strk>
Project Member
Thu 05 Jun 2008 02:35:03 AM UTC, original submission:

I guess my last successful build didn't include r1.49.2.2 of libbase/utility.h since building fails with the following error. Reverting to 1.49.2.1 fixes it for OpenBSD.

In file included from jpeg.cpp:10:
utility.h: In function `float std::infinite_to_fzero(float)':
utility.h:98: error: `isfinite' undeclared (first use this function)
utility.h:98: error: (Each undeclared identifier is reported only once for each
function it appears in.)
gmake[2]: *** [libgnashbase_la-jpeg.lo] Error 1
gmake[2]: Leaving directory `/usr/ports/www/gnash/w-gnash-0.8.3/gnash-0.8.3/libbase'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/usr/ports/www/gnash/w-gnash-0.8.3/gnash-0.8.3'
gmake: *** [all] Error 2

      • Error code 2

Stop in /usr/ports/www/gnash (line 2139 of /usr/ports/infrastructure/mk/bsd.port.mk).

Deanna Phillips <deanna>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bwy (Posted a comment)
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by strk
  • -unavailable- added by deanna (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 05 Jun 2008 04:03:41 PM UTCbwyStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Thu 05 Jun 2008 06:00:20 AM UTCstrkCategoryNone=>build
      Severity3 - Normal=>4 - Important
      Assigned toNone=>bwy
      Carbon-Copy-=>Added dossy

    Back to the top


    Powered by Savane 3.1-cleanup1