bugGnash - The GNU Flash player - Bugs: bug #23490, swfdec testcase crashes Gnash

 
 

bug #23490: swfdec testcase crashes Gnash

Submitted by:  Benjamin Wolsey <bwy>
Submitted on:  Wed 04 Jun 2008 08:06:57 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Benjamin Wolsey <bwy>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 11 Jun 2008 09:02:13 PM UTC, comment #4:

I've fixed the crash and it seems that try / catch / finally is now almost completely correct.

There is one element of it - catch-in-register, that is practically untested, and which I have no documentation about. I've guessed about how it should be implemented - whatever I do with it, it seems to have no effect on the 'normal' cases - so how far away it is from being right is anyone's guess.

Benjamin Wolsey <bwy>
Project MemberIn charge of this item.
Wed 11 Jun 2008 09:36:56 AM UTC, comment #3:

try / catch / finally is not correct in Gnash; I'll look at fixing that first, then see about this problem.

Benjamin Wolsey <bwy>
Project MemberIn charge of this item.
Wed 04 Jun 2008 08:41:45 PM UTC, comment #2:

From the description seems easy to fix (the abort).
Getting the correct behaviour might be harder, but I've no
idea as Chad did that part.

Sandro Santilli <strk>
Project Member
Wed 04 Jun 2008 08:40:19 PM UTC, comment #1:

It's a newly added case (28th of May), so quite likely not a regression.

Benjamin Wolsey <bwy>
Project MemberIn charge of this item.
Wed 04 Jun 2008 08:06:57 PM UTC, original submission:

Gnash fails an assertion because the catch name is empty. I've checked and it is indeed empty. Not sure whether the bug is that we should handle empty catch names without aborting or that the catch block shouldn't be there at all.

lt-gtk-gnash: /home/benjamin/Download/gnash/server/as_environment.cpp:412: void gnash::as_environment::set_local(const std::string&, const gnash::as_value&): assertion »! varname.empty()« failed.

#3 0x00002b0e5517036b in gnash::as_environment::set_local (this=0xa3b7e8, varname=@0xa4cc28, val=@0x7fff56096c90)
at /home/benjamin/Download/gnash/server/as_environment.cpp:412
#4 0x00002b0e553508f3 in gnash::ActionExec::operator() (this=0x7fff56096dd0) at /home/benjamin/Download/gnash/server/vm/ActionExec.cpp:202
#5 0x00002b0e55202564 in gnash::swf_function::operator() (this=0xa4bbd0, fn=@0x7fff56097220) at /home/benjamin/Download/gnash/server/swf_function.cpp:298
#6 0x00002b0e5535634b in gnash::call_method (method=@0x7fff56097300, env=0xa3b7e8, this_ptr=<value optimized out>, nargs=0, first_arg_bottom_index=-1,
super=0x0) at /home/benjamin/Download/gnash/server/vm/action.cpp:72
#7 0x00002b0e5532603d in gnash::SWF::SWFHandlers::ActionCallFunction (thread=@0x7fff56097820)
at /home/benjamin/Download/gnash/server/vm/ASHandlers.cpp:2830
#8 0x00002b0e553236fb in gnash::SWF::SWFHandlers::execute (this=<value optimized out>, type=<value optimized out>, thread=@0x7fff56097820)
at /home/benjamin/Download/gnash/server/vm/ASHandlers.cpp:449

Benjamin Wolsey <bwy>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #15797:  try-return-in-finally.as added by bwy (247B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by bwy (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 19 Jun 2008 07:18:40 AM UTCbwyStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Wed 11 Jun 2008 09:02:13 PM UTCbwyStatusIn Progress=>Ready For Test
    Wed 11 Jun 2008 09:36:56 AM UTCbwyStatusNone=>In Progress
      Assigned toNone=>bwy
    Wed 04 Jun 2008 08:06:57 PM UTCbwyAttached File-=>Added try-return-in-finally.as, #15797

    Back to the top


    Powered by Savane 3.1-cleanup1